IPB

Welcome Guest ( Log In | Register )

 
Reply to this topicStart new topic
> [F] Action Groups 'Close', V2.44
chrisjj
post Sep 10 2009, 16:33
Post #1


Member


Group: Full Members
Posts: 1500
Joined: 25-October 05
Member No.: 2273
Mp3tag Version: -



The Action Groups dialog button that does 'close' is mislabelled Cancel. It does not cancel. It just closes.

This post has been edited by chrisjj: Sep 24 2009, 11:52
Go to the top of the page
 
+Quote Post
Florian
post Oct 18 2009, 11:54
Post #2


Developer


Group: Admin
Posts: 7723
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.65



I think labelling this button with Cancel is OK at this point.


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post
chrisjj
post Oct 18 2009, 13:18
Post #3


Member


Group: Full Members
Posts: 1500
Joined: 25-October 05
Member No.: 2273
Mp3tag Version: -



How so? The button doesn't cancel.
Go to the top of the page
 
+Quote Post
Florian
post Oct 18 2009, 13:22
Post #4


Developer


Group: Admin
Posts: 7723
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.65



It cancels the workflow the user started by clicking on mt_format.png


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post
chrisjj
post Oct 18 2009, 13:45
Post #5


Member


Group: Full Members
Posts: 1500
Joined: 25-October 05
Member No.: 2273
Mp3tag Version: -



> It cancels the workflow the user started by clicking on mt_format.png

Not here, Florian.

Click mt_format.png, click New, enter TEST, click OK, click Cancel.
Click mt_format.png, see TEST is present - the Cancel failed.

Contrast with:

Click mt_format.png, click New, enter TEST, click Cancel
See TEST is NOT present - the Cancel succeeded.

Go to the top of the page
 
+Quote Post
Florian
post Oct 18 2009, 21:17
Post #6


Developer


Group: Admin
Posts: 7723
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.65



I see, thanks for the explanation.

Marked as [C] now.


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post
gvm
post Oct 26 2009, 17:12
Post #7


Member


Group: Full Members
Posts: 55
Joined: 26-October 09
Member No.: 11175
Mp3tag Version: 2.46a



QUOTE (chrisjj @ Oct 18 2009, 14:45) *
> It cancels the workflow the user started by clicking on mt_format.png

Not here, Florian.

Click mt_format.png, click New, enter TEST, click OK, click Cancel.
Click mt_format.png, see TEST is present - the Cancel failed.

Contrast with:

Click mt_format.png, click New, enter TEST, click Cancel
See TEST is NOT present - the Cancel succeeded.


It would be best to have both of these actions as choices for this dialog box. Rather than just change the functionality of the existing button, it would be useful to be have an extra button to allow the choice of "Execute"(keep changes and execute), "Save" (keep changes but don't execute) and "Cancel" (don't execute and discard changes).

Regards,

gvm
Go to the top of the page
 
+Quote Post
Florian
post Oct 31 2009, 18:48
Post #8


Developer


Group: Admin
Posts: 7723
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.65



I've changed the label with Mp3tag v2.44f Development Build.

Kind regards,
Florian


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post

Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 23rd October 2014 - 22:57