IPB

Welcome Guest ( Log In | Register )

 
Reply to this topicStart new topic
> [F] Actions creating empty tag fields unnecessarily
Oblio
post Apr 21 2008, 07:47
Post #1


Member


Group: Full Members
Posts: 137
Joined: 12-June 06
From: Australia
Member No.: 3286
Mp3tag Version: 2.54



I noticed when running actions on a tag field if the field does not exist in the tag, the action will create the field anyway with nothing in it!

Actions such as Replace or Case Conversion seem to imply that they will affect only existing fields whereas Format Value you would imagine will always result in a field being written.

Should some actions only write to the field if the tag already contains that particular field to prevent the empty fields being created?
Go to the top of the page
 
+Quote Post
Florian
post Apr 28 2008, 22:37
Post #2


Developer


Group: Admin
Posts: 7661
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.59a



This sounds like a good idea too me.

Can you give an example of such an action?


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post
Oblio
post May 1 2008, 07:22
Post #3


Member


Group: Full Members
Posts: 137
Joined: 12-June 06
From: Australia
Member No.: 3286
Mp3tag Version: 2.54



These actions should only affect existing fields and not create empty fields in the tag

Case conversion
Convert codepage
Replace
Replace with regular expression


e.g. Replace "The" => "the" in comment field. Run on a group of files. Any file which didn't already have a comment field will now have an empty comment field.

Maybe its not such a big deal?



QUOTE (Florian @ Apr 29 2008, 07:37) *
This sounds like a good idea too me.

Can you give an example of such an action?
Go to the top of the page
 
+Quote Post
dano
post May 2 2008, 00:31
Post #4


Moderator


Group: Moderators
Posts: 5673
Joined: 4-September 03
From: Germany
Member No.: 201
Mp3tag Version: 2.59a



An empty tag field is displayed, but no actual tag field is created. Some visual bug.


--------------------
Go to the top of the page
 
+Quote Post
chrisjj
post May 2 2008, 11:37
Post #5


Member


Group: Full Members
Posts: 1359
Joined: 25-October 05
Member No.: 2273
Mp3tag Version: -



> Maybe its not such a big deal?

Big enough. Here on a 10K-track set it caused bloat of files and massive bloat of the backup.

Anyone know a workaround? Extended Tags won't show the tag for me to delete it.

QUOTE (dano @ May 2 2008, 00:31) *
An empty tag field is displayed, but no actual tag field is created. Some visual bug.
I get the reverse - no display (see http://forums.mp3tag.de/index.php?showtopic=7685) but yes tag (see same).

This post has been edited by chrisjj: May 4 2008, 13:29
Go to the top of the page
 
+Quote Post
dano
post May 2 2008, 13:35
Post #6


Moderator


Group: Moderators
Posts: 5673
Joined: 4-September 03
From: Germany
Member No.: 201
Mp3tag Version: 2.59a



QUOTE (chrisjj @ May 2 2008, 12:37) *
I get the reverse - no display (see http://forums.mp3tag.de/index.php?showtopic=7685) but yes tag (see same).

That is a different case.


--------------------
Go to the top of the page
 
+Quote Post
Florian
post May 2 2008, 16:50
Post #7


Developer


Group: Admin
Posts: 7661
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.59a



QUOTE (Oblio @ May 1 2008, 08:22) *
These actions should only affect existing fields and not create empty fields in the tag

OK. Thanks for reporting, I'll fix it to the next release (though the empty fields are not written to the tags).

Kind regards,
Florian


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post
chrisjj
post May 3 2008, 23:26
Post #8


Member


Group: Full Members
Posts: 1359
Joined: 25-October 05
Member No.: 2273
Mp3tag Version: -



QUOTE (dano @ May 2 2008, 13:35) *
That is a different case.
How so? It can arise just as Oblio reports.

This post has been edited by chrisjj: May 4 2008, 13:29
Go to the top of the page
 
+Quote Post
Oblio
post May 7 2008, 05:36
Post #9


Member


Group: Full Members
Posts: 137
Joined: 12-June 06
From: Australia
Member No.: 3286
Mp3tag Version: 2.54



QUOTE (dano @ May 2 2008, 09:31) *
An empty tag field is displayed, but no actual tag field is created. Some visual bug.


I noticed that visual glitch too but that is not what I am reporting. I have 100s of files with empty TIT3 tags to prove it!

It seems to only happen if action is part of an action group but I am having trouble replicating the issue. Will report back if I can narrow it down.
Go to the top of the page
 
+Quote Post
chrisjj
post May 7 2008, 21:27
Post #10


Member


Group: Full Members
Posts: 1359
Joined: 25-October 05
Member No.: 2273
Mp3tag Version: -



QUOTE (Oblio @ May 7 2008, 05:36) *
It seems to only happen if action is part of an action group
I thought actions had to be!

QUOTE
but I am having trouble replicating the issue.
FWIW the recipe here (V2.41) is simply

1 Load an mp3 having no CJJTEMP tag
2 Convert Actions with an Action Group containing one Action:
Replace "CJJTEMP": "a" -> "a" (case-sensitive comparison)

Now the file has an empty CJJTEMP tag. Every time.
Go to the top of the page
 
+Quote Post
Oblio
post May 9 2008, 06:47
Post #11


Member


Group: Full Members
Posts: 137
Joined: 12-June 06
From: Australia
Member No.: 3286
Mp3tag Version: 2.54



QUOTE (chrisjj @ May 8 2008, 06:27) *
Now the file has an empty CJJTEMP tag. Every time.

Not quite

What I am seeing is this. After the action is run, the extended tags dialog shows the empty field but it is not written into the tag yet. If you OK out of the extended tags dialog the tag is updated - the empty field disappears and is not written into the tag. However if you cancel out of the extended tags dialog and then click save button the empty field disappears from the extended tags dialog but is written into the tag.
Go to the top of the page
 
+Quote Post
chrisjj
post May 12 2008, 14:55
Post #12


Member


Group: Full Members
Posts: 1359
Joined: 25-October 05
Member No.: 2273
Mp3tag Version: -



> After the action is run, the extended tags dialog shows the empty field but it
> is not written into the tag yet.

Confirmed.

> However if you cancel out of the extended tags dialog and then click save
> button the empty field disappears from the extended tags dialog but is written into the tag.

Confirmed - my recipe needs a final Save to be correct.

Nice catch Oblio!
Go to the top of the page
 
+Quote Post
Florian
post Jun 6 2008, 21:02
Post #13


Developer


Group: Admin
Posts: 7661
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.59a



QUOTE (Florian @ May 2 2008, 17:50) *
OK. Thanks for reporting, I'll fix it to the next release (though the empty fields are not written to the tags).


This is now fixed in the latest Development Build Mp3tag v2.41a.

Kind regards,
Florian


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post

Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 23rd April 2014 - 12:49