IPB

Welcome Guest ( Log In | Register )

7 Pages V  « < 2 3 4 5 6 > »   
Reply to this topicStart new topic
> Whole Album/Directory Lyrics Tool, Created a Lyrics Tool... help me improve it :)
soehest
post Mar 19 2012, 00:25
Post #46


Member


Group: Members
Posts: 4
Joined: 18-March 12
Member No.: 16211
Mp3tag Version: 2.39



I like this tool but it seems to be choking for me on large collections:

I am getting this error (attached as screenshot every time i run it on my music folder 4000+ files)

Best Regards

Attached Image
Go to the top of the page
 
+Quote Post
ResidualImages
post Mar 19 2012, 00:34
Post #47


Member


Group: Full Members
Posts: 47
Joined: 8-June 08
From: Central Texas
Member No.: 7166
Mp3tag Version: 2.46a



QUOTE (soehest @ Mar 18 2012, 18:25) *
I like this tool but it seems to be choking for me on large collections:

I am getting this error (attached as screenshot every time i run it on my music folder 4000+ files)

Best Regards

Attached Image


Exciting! I'll look into that error this week as well. something specific about what you're doing has exposed a flaw in my code somewhere.

Thank you; if I can't track it down, I may ask a question or two of you. But that type of error is usually fixed by correcting some dumb line I overlooked.

Glad you like it, now let's get rid of that error tongue.gif
Go to the top of the page
 
+Quote Post
soehest
post Mar 19 2012, 17:00
Post #48


Member


Group: Members
Posts: 4
Joined: 18-March 12
Member No.: 16211
Mp3tag Version: 2.39



Oh no new issue biggrin.gif

Getting this on some songs:

Unfortunately, we are not licensed to display the full lyrics for this song at the moment. Hopefully we will be able to in the future. Until then, how about a random page?
[I want to edit metadata]

There needs to be a check to stop downloading those lyrics as they are not complete. I have no clue to what criteria sets this off.
Go to the top of the page
 
+Quote Post
ResidualImages
post Mar 19 2012, 17:02
Post #49


Member


Group: Full Members
Posts: 47
Joined: 8-June 08
From: Central Texas
Member No.: 7166
Mp3tag Version: 2.46a



QUOTE (soehest @ Mar 19 2012, 11:00) *
Oh no new issue biggrin.gif

Getting this on some songs:

Unfortunately, we are not licensed to display the full lyrics for this song at the moment. Hopefully we will be able to in the future. Until then, how about a random page?
[I want to edit metadata]

There needs to be a check to stop downloading those lyrics as they are not complete. I have no clue to what criteria sets this off.


good job, haha. I know that's possible to happen, but I had never seen it actually happen. I'll put a check in there for that.
Go to the top of the page
 
+Quote Post
soehest
post Mar 19 2012, 17:19
Post #50


Member


Group: Members
Posts: 4
Joined: 18-March 12
Member No.: 16211
Mp3tag Version: 2.39



QUOTE (ResidualImages @ Mar 19 2012, 17:02) *
good job, haha. I know that's possible to happen, but I had never seen it actually happen. I'll put a check in there for that.


Hehe i find the odd bugs ;-) There is an example here to help you test:
http://lyrics.wikia.com/Tool:Intolerance

:-)
Go to the top of the page
 
+Quote Post
ResidualImages
post Mar 30 2012, 21:48
Post #51


Member


Group: Full Members
Posts: 47
Joined: 8-June 08
From: Central Texas
Member No.: 7166
Mp3tag Version: 2.46a



alright, there's a small revision now.

this will allow you to hide the summary window (per LyricsLover's request)

it will also ignore lyrics with the "sorry, life sucks and we aren't allowed to give you the full lyrics" disclaimer tongue.gif

and finally, soehest, please see if your error still happens for the 4000+ files folder.

This post has been edited by ResidualImages: Mar 30 2012, 21:49
Go to the top of the page
 
+Quote Post
bobjonst
post Mar 31 2012, 09:18
Post #52


Member


Group: Members
Posts: 1
Joined: 31-March 12
Member No.: 16271
Mp3tag Version: 2.47b



Hey I dont know if this was mentioned before. I really like the tool, it does the job very well. It would be very nice to have an option to search for song lyrics without the artist name. That way one can find lyrics for songs that were covered by different artists.

Great work overall, thanks!
Go to the top of the page
 
+Quote Post
soehest
post Apr 2 2012, 12:51
Post #53


Member


Group: Members
Posts: 4
Joined: 18-March 12
Member No.: 16211
Mp3tag Version: 2.39



QUOTE (ResidualImages @ Mar 30 2012, 22:48) *
alright, there's a small revision now.

this will allow you to hide the summary window (per LyricsLover's request)

it will also ignore lyrics with the "sorry, life sucks and we aren't allowed to give you the full lyrics" disclaimer tongue.gif

and finally, soehest, please see if your error still happens for the 4000+ files folder.


Nice new revision walkman.gif
I can say that my test run on my 4000+ folder ran perfectly without crashing like last time, so you did manage to fix that bug :-) Also it will no longer fetch those teaser lyrics. Great work :-)

Best regards
soehest
Go to the top of the page
 
+Quote Post
tbum20
post Apr 2 2012, 18:27
Post #54


Member


Group: Full Members
Posts: 17
Joined: 20-January 11
Member No.: 13645
Mp3tag Version: 2.47b



bobjonst makes a good point, Thanks a lot for taking the time to pick this project backup and keep it running to perfection. Its a great tool, props!

Tbum
Go to the top of the page
 
+Quote Post
ResidualImages
post Apr 3 2012, 13:19
Post #55


Member


Group: Full Members
Posts: 47
Joined: 8-June 08
From: Central Texas
Member No.: 7166
Mp3tag Version: 2.46a



QUOTE (bobjonst @ Mar 31 2012, 03:18) *
Hey I dont know if this was mentioned before. I really like the tool, it does the job very well.
Great work overall, thanks!


thank you for your kind words! smile.gif

QUOTE (bobjonst @ Mar 31 2012, 03:18) *
It would be very nice to have an option to search for song lyrics without the artist name. That way one can find lyrics for songs that were covered by different artists.

this should be possible, but I'll have to think of how to actually implement it cleanly. There will probably have to be a 2nd export 'action' set up in MP3Tag to do covers/songs without artists.
Go to the top of the page
 
+Quote Post
ResidualImages
post Apr 3 2012, 13:22
Post #56


Member


Group: Full Members
Posts: 47
Joined: 8-June 08
From: Central Texas
Member No.: 7166
Mp3tag Version: 2.46a



QUOTE (soehest @ Apr 2 2012, 06:51) *
Nice new revision walkman.gif
I can say that my test run on my 4000+ folder ran perfectly without crashing like last time, so you did manage to fix that bug :-) Also it will no longer fetch those teaser lyrics. Great work :-)

Best regards
soehest



soehest, that's the kind of reply that really makes my day. "no problems, we're all good here" is a wonderful feeling biggrin.gif

thanks for your time finding the bugs. feel free to pass along any other things you find or think of as improvements~
Go to the top of the page
 
+Quote Post
ResidualImages
post Apr 3 2012, 13:24
Post #57


Member


Group: Full Members
Posts: 47
Joined: 8-June 08
From: Central Texas
Member No.: 7166
Mp3tag Version: 2.46a



QUOTE (tbum20 @ Apr 2 2012, 12:27) *
bobjonst makes a good point, Thanks a lot for taking the time to pick this project backup and keep it running to perfection. Its a great tool, props!

Tbum


Tbum, thanks for your support. Sure, I like having the tool for myself, but sharing it and having solid feedback is awesome! laugh.gif
Go to the top of the page
 
+Quote Post
Usram
post Apr 12 2012, 12:39
Post #58


Member


Group: Members
Posts: 2
Joined: 12-April 12
Member No.: 16325
Mp3tag Version: 2.53



Very good job. Thank's a lot for all your efforts and time biggrin.gif
Go to the top of the page
 
+Quote Post
ResidualImages
post Apr 12 2012, 13:07
Post #59


Member


Group: Full Members
Posts: 47
Joined: 8-June 08
From: Central Texas
Member No.: 7166
Mp3tag Version: 2.46a



QUOTE (Usram @ Apr 12 2012, 06:39) *
Very good job. Thank's a lot for all your efforts and time biggrin.gif



thanks Usram! and welcome to the forums smile.gif
Go to the top of the page
 
+Quote Post
entdh
post Apr 12 2012, 17:33
Post #60


Member


Group: Full Members
Posts: 10
Joined: 12-April 12
Member No.: 16326
Mp3tag Version: 2.5



Hello
this is my first post, this tool is exactly what I have been looking for and works for me pretty well, but I wonder if I did something wrong?
it seems to take ages just to do an album or 2 (around 10 -15 minutes?) and will hang sometimes with loads of little windows open and state 'internet explorer has stopped working'
I use windows 7 and IE9 if that is important?

otherwise keep up the good work
thanks
entdh
Go to the top of the page
 
+Quote Post

7 Pages V  « < 2 3 4 5 6 > » 
Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 17th April 2014 - 04:57