IPB

Welcome Guest ( Log In | Register )

16 Pages V  < 1 2 3 4 5 > »   
Reply to this topicStart new topic
> [WS] Discogs ALL, Uses Discogs API sevice
Innuendo
post Oct 20 2009, 14:35
Post #31


Member


Group: Full Members
Posts: 49
Joined: 18-October 09
Member No.: 11114
Mp3tag Version: 2.50



QUOTE (Pufas @ Oct 20 2009, 03:15) *
Hmmm, worked fine for me with this. Could you please post what release you where tagging?


I think what we're dealing with is Discogs not being consistent with how information is displayed. I noticed on your example track the Lead Vocals are listed for each track. However, the release I was testing lists the vocals and lead vocals down in the credits as seen here.

As you can see from the layout of this release it's an excellent test for scripts as it has numerous engineer, photography, and artwork entries. It'd be really nice if the "Notes" section could end up in a tag somewhere, too.

Hope you don't see all my messages as complaining. I just want to help you work all the bugs out. smile.gif
Go to the top of the page
 
+Quote Post
Pufas
post Oct 20 2009, 18:20
Post #32


Member


Group: Full Members
Posts: 77
Joined: 31-October 07
From: Lithuania, Kaunas
Member No.: 5857
Mp3tag Version: 2.49a



QUOTE (Innuendo @ Oct 20 2009, 14:35) *
I think what we're dealing with is Discogs not being consistent with how information is displayed. I noticed on your example track the Lead Vocals are listed for each track. However, the release I was testing lists the vocals and lead vocals down in the credits as seen here.

As you can see from the layout of this release it's an excellent test for scripts as it has numerous engineer, photography, and artwork entries. It'd be really nice if the "Notes" section could end up in a tag somewhere, too.

Hope you don't see all my messages as complaining. I just want to help you work all the bugs out. smile.gif


Yes, I'll see what I can do. I'll be working with notes, as soon as we're done with credits.
About "complaining" - well, I'm glad to hear it. smile.gif


--------------------
()/)
( '.') <( MP3TAG kicks ass! )
((')(')
Go to the top of the page
 
+Quote Post
Innuendo
post Oct 20 2009, 18:41
Post #33


Member


Group: Full Members
Posts: 49
Joined: 18-October 09
Member No.: 11114
Mp3tag Version: 2.50



QUOTE (Pufas @ Oct 20 2009, 12:20) *
Yes, I'll see what I can do. I'll be working with notes, as soon as we're done with credits.
About "complaining" - well, I'm glad to hear it. smile.gif


Here is another example of where your otherwise excellent script picks up the backup vocals instead of the lead vocals.
Go to the top of the page
 
+Quote Post
Pufas
post Oct 20 2009, 20:07
Post #34


Member


Group: Full Members
Posts: 77
Joined: 31-October 07
From: Lithuania, Kaunas
Member No.: 5857
Mp3tag Version: 2.49a



Fixed & re-posted. Now I'll get on to NOTES.
BTW, if you know any release with heavily formatted notes (italic, bold, hyperlinks and ect.), please post it, that would be helpful.


--------------------
()/)
( '.') <( MP3TAG kicks ass! )
((')(')
Go to the top of the page
 
+Quote Post
Innuendo
post Oct 22 2009, 20:26
Post #35


Member


Group: Full Members
Posts: 49
Joined: 18-October 09
Member No.: 11114
Mp3tag Version: 2.50



QUOTE (Pufas @ Oct 20 2009, 14:07) *
Fixed & re-posted. Now I'll get on to NOTES.
BTW, if you know any release with heavily formatted notes (italic, bold, hyperlinks and ect.), please post it, that would be helpful.


I've been looking for some notes like that, but I guess I either have boring music or nothing really note-worthy as all the releases I have checked so far don't have any formatting like that at all.
Go to the top of the page
 
+Quote Post
Pufas
post Oct 22 2009, 20:33
Post #36


Member


Group: Full Members
Posts: 77
Joined: 31-October 07
From: Lithuania, Kaunas
Member No.: 5857
Mp3tag Version: 2.49a



QUOTE (Innuendo @ Oct 22 2009, 20:26) *
I've been looking for some notes like that, but I guess I either have boring music or nothing really note-worthy as all the releases I have checked so far don't have any formatting like that at all.


I'm done with the notes, but I'll post when I'll fix some more stuff.


--------------------
()/)
( '.') <( MP3TAG kicks ass! )
((')(')
Go to the top of the page
 
+Quote Post
Innuendo
post Oct 23 2009, 01:07
Post #37


Member


Group: Full Members
Posts: 49
Joined: 18-October 09
Member No.: 11114
Mp3tag Version: 2.50



QUOTE (Pufas @ Oct 22 2009, 14:33) *
I'm done with the notes, but I'll post when I'll fix some more stuff.


I'll keep checking back looking for it then.
Go to the top of the page
 
+Quote Post
morrison
post Oct 23 2009, 10:49
Post #38


Member


Group: Full Members
Posts: 66
Joined: 11-October 07
From: Russia
Member No.: 5762
Mp3tag Version: 2.50



cannot receive information about this release - http://www.discogs.com/release/1671758 (I fix this in my temporary version). I think this is because one of main field (Style) is empty.

sorry for my English

This post has been edited by morrison: Oct 23 2009, 11:01
Go to the top of the page
 
+Quote Post
Pufas
post Oct 23 2009, 10:57
Post #39


Member


Group: Full Members
Posts: 77
Joined: 31-October 07
From: Lithuania, Kaunas
Member No.: 5857
Mp3tag Version: 2.49a



QUOTE (morrison @ Oct 23 2009, 10:49) *
cannot receive information about this release - http://www.discogs.com/release/1671758 (I fix this in my temporary version). I think this is because one of main field (Style) is empty.

sorry for my English


I know this bug and I'm working on that.


--------------------
()/)
( '.') <( MP3TAG kicks ass! )
((')(')
Go to the top of the page
 
+Quote Post
morrison
post Oct 23 2009, 11:07
Post #40


Member


Group: Full Members
Posts: 66
Joined: 11-October 07
From: Russia
Member No.: 5762
Mp3tag Version: 2.50



if this can help, I fix this with this:

# STYLE
gotochar 1
findinline "</genres>"
if "<styles>"
outputto "STYLE"
replace "</style><style>" ", "
findinline "<style>"
sayuntil "</style>"
endif

upd:

and another strange moment in your script:
if "Vocals"
outputto "VOCALS"
outputto "VOCALS"


This post has been edited by morrison: Oct 23 2009, 13:19
Go to the top of the page
 
+Quote Post
Pufas
post Oct 23 2009, 22:19
Post #41


Member


Group: Full Members
Posts: 77
Joined: 31-October 07
From: Lithuania, Kaunas
Member No.: 5857
Mp3tag Version: 2.49a



QUOTE (morrison @ Oct 23 2009, 11:07) *
if this can help, I fix this with this:

# STYLE
gotochar 1
findinline "</genres>"
if "<styles>"
outputto "STYLE"
replace "</style><style>" ", "
findinline "<style>"
sayuntil "</style>"
endif

upd:

and another strange moment in your script:
if "Vocals"
outputto "VOCALS"
outputto "VOCALS"


thank you for caring, but i would had it fixed that long long time ago, but i believe i encountered some mp3tag bugs. I've asked dano for some help, and i'm waiting for reply.

and that 2x outputto "VOCALS" - it's just a minor type error. Still thank you for reporting that.


--------------------
()/)
( '.') <( MP3TAG kicks ass! )
((')(')
Go to the top of the page
 
+Quote Post
morrison
post Oct 24 2009, 00:00
Post #42


Member


Group: Full Members
Posts: 66
Joined: 11-October 07
From: Russia
Member No.: 5762
Mp3tag Version: 2.50



QUOTE (Pufas @ Oct 24 2009, 01:19) *
thank you for caring, but i would had it fixed that long long time ago, but i believe i encountered some mp3tag bugs. I've asked dano for some help, and i'm waiting for reply.

and that 2x outputto "VOCALS" - it's just a minor type error. Still thank you for reporting that.


NP, I reported only for your convenience smile.gif
Go to the top of the page
 
+Quote Post
Pufas
post Oct 24 2009, 11:54
Post #43


Member


Group: Full Members
Posts: 77
Joined: 31-October 07
From: Lithuania, Kaunas
Member No.: 5857
Mp3tag Version: 2.49a



I added new version of script. However "empty fields bug" remains unsolved. Script contains code which "should" solve everything. If someone finds what's wrong with it, that would be nice. For now, I'll wait a bit for dano's reply.


--------------------
()/)
( '.') <( MP3TAG kicks ass! )
((')(')
Go to the top of the page
 
+Quote Post
dano
post Oct 24 2009, 13:08
Post #44


Moderator


Group: Moderators
Posts: 5688
Joined: 4-September 03
From: Germany
Member No.: 201
Mp3tag Version: 2.65



With Mp3tag 2.44e it will not display empty tag fields anymore, so to remove a temporary tag field, just set it empty:
set "TMP1"

Then you won't see it anymore in the tag window.

Btw why do you use
say " "
on all notes fields e.g.
outputto "VOCALS"
say " "


--------------------
Go to the top of the page
 
+Quote Post
Windjammer
post Oct 24 2009, 15:08
Post #45


Member


Group: Full Members
Posts: 80
Joined: 22-April 05
From: Barcelona, ESP
Member No.: 1756
Mp3tag Version: 2.56



QUOTE (dano @ Oct 24 2009, 14:08) *
With Mp3tag 2.44e it will not display empty tag fields anymore, so to remove a temporary tag field, just set it empty:
set "TMP1"

Then you won't see it anymore in the tag window.

Btw why do you use
say " "
on all notes fields e.g.
outputto "VOCALS"
say " "


This is probably correct, but Pufas scrip adds a space " " to all empty tags so it still generates a lot of "empty" tags...
Go to the top of the page
 
+Quote Post

16 Pages V  < 1 2 3 4 5 > » 
Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 23rd October 2014 - 11:09