Help - Search - Members - Calendar
Full Version: Whole Album/Directory Lyrics Tool
Mp3tag Forums > Mp3tag - International > Development > Web Sources Scripts
Pages: 1, 2, 3
ResidualImages
New Version 1.0.0.19



'Lyrics' is released without warranty or implied fitness for a particular purpose.
This is fan-created for use by other fans of MP3Tag and AutoIT. Now with Lyrics Wiki data!

Any questions should be directed at Matt_Burke@baylor.edu

There are major changes to the .10+ version. There are now 3 steps. Export, Get Lyrics, and Import Lyrics. There is a Readme.PDF in the zip; I'll provide a Google Docs version here.

This tool relies on Internet Explorer being installed on your machine, and may from time to time create an Internet Explorer window that you can see. Feel free to close this window; I'm not sure why the object, which is set to IEobject.visible = false, is sometimes visible and doesn't automatically close. This has been optimized out, so it only uses one instance of Internet Explorer through the entire process. I have noticed that sometimes audio advertisements on the lyricswiki.com or darklyrics.com sites will begin to play on this invisible window. don't worry, you didn't suddenly get ghosts in your computer tongue.gif

SPEAKING OF WHICH:
This tool now defaults to LyricsWiki.com as its lookup; however, per Luctus's request, I have the option of DarkLyrics.com lookups as an alternative. Please review the changes in the Readme.pdf file, but feel free to ask for clarification or assistance. I have also just added ViewLyrics.com as an option, per Zedicus's request.

You can also just use the executable outside of MP3tag to get the lyrics ahead of time for complete directories or specific files. That way, you can just have an "import lyrics" action in MP3tag, and thereby skip the first 2 of the 3 steps in the above PDF. However, running the executable relies on parts of Windows that may not ship standard in European editions of Windows. That is why there is the option to create an 'Export file' from within MP3tag.

New "-quiet" feature to bypass summary window, and improvements to code that may address the 'variable error' issues that soehest found.

New "-nostrip" feature to skip the check for cell phone ringtone advertisement lines in lyrics from LyricsWiki. This feature is to address the missing lines that tappan is experiencing.

Also, like soehest also found, LyricsWiki has some songs that they give 'teaser' lyrics for, but are not allowed to display full lyrics. these are now treated as if the lyrics were not found at all.


Feedback welcome and appreciated.

~Matt
ouisltagger
This tool will be awesome! I've been wanting to tag lyrics to a bunch of files at once (and I'm sure I'm not the only one), and this works great...when it works. The DarkLyrics script works good for this, except it only works with metal...which I have a lot of, but I'd like to tag more than that, of course. I get AutoIt errors, sometimes it wants to save non-text files, or it doesn't find stuff on the first try. Sometimes it notifies you it's done and sometimes it doesn't. Sometimes it works perfectly when run on a couple albums. I haven't been able to figure out a pattern. But when it works right, I couldn't ask for much more. Please keep up the work on it so it works consistently! Thanks for posting it in the first place! Unfortunately, I don't have any ideas to help with the instability...even AutoIt is a bit over my head. I did make an import action though, for those who want instructions:

Actions -> New -> (Name of action group = Import lyrics, for example)

New -> Select Action type = Import text file -> OK

Field = UNSYNCEDLYRICS, Filename = %title%.txt -> OK -> OK

Hope that can help someone else test this out!
ResidualImages
alright. sorry i've been out of town and such during the summer, and therefore taken a long time to respond.

what errors do you get, if you can bring them up again? I've not gotten ANY auto-it errors on my machine personally, so i need to know what it's complaining about on your system.

I'm still working on making a good process for saving incorrect file-names. i'm realizing now how many songs i have whose titles don't create filenames allowed under windows. i hadn't heard from anyone else using this so i just wasn't worrying about it. now i shall renew my efforts. smile.gif

When you say "it doesn't find stuff on the first try" ... do you change anything about the tags on the file and then it works, or you just run it again? i've noticed a few times where it runs but exits immediately and i am tracking down that bug. just want to know what you're speaking of, to make sure it's the same issue as i've seen.

as far as the notification, i'm working on making it so it only runs the program as one instance instead of however many files you selected lol.
what's the max. amount of songs you've successfully run this with?

THANK YOU SO MUCH FOR YOUR FEEDBACK. This is one of my most used tools personally, even if it's rough, but feedback will make it much more. smile.gif
ouisltagger
After using the script for a little bit I found a component for foobar2000 that is extremely simple and great for getting lyrics, Lyrics Grabber (foo_lyricsgrabber). http://www.hydrogenaudio.org/forums/index....showtopic=62821 . So I don't have too much feedback. But I like to work in mp3tag rather than foobar2000, since I don't like how you can spend hours with that foobar2000 interface to set it up nicely, and I normally use Winamp for my player.

When the script wouldn't find anything, I wouldn't change the mp3 files, I would just run it again, and would often get better, or worse results. But besides running it again, I didn't make changes.

I think I may have run about 100 songs successfully, but based on how it's operating, it doesn't seem like the number of files chosen has anything to do with the success of getting successful results. But I can't exactly remember now. I think it may have worked fine when choosing one file at a time.

If you release a newer version, I'd be happy to test it out again. Maybe checking out that foobar component can help. It's impressive, I've had no problems with it and it gets good quality lyrics. One note though on that foobar2000 component if you look into it, I did have to change the lyrics field from its default to UNSYNCEDLYRICS to get the compatibility I wanted. Thanks for your script, I hope I've been of help!
ResidualImages
i'll look into their work as well, maybe bring something to MP3tagger that'll perform similarly. looks like they're using lyricswiki for their data; i may see how complete that database is vs. the lyricsplugin i've been using

i'll try to figure out why it works sometimes and not others more aggresively

the number of files shouldn't affect its working or not, but may slow your computer down is why i put that idea of a limit in there, since it runs a separate instance of the program for every file. i am thinking of a way to change it so you run the program once with all the files, rather than separately.

you've been of great help and i will certainly post back with a new version in the next couple weeks. going out of town this weekend again, or i'd have one for you and i to try by monday haha.
ResidualImages
Original post edited
Mike_nl
I got an error:

***** ERROR: TIMEOUT Did NOT find lyrics for '0:03:41' by French Pop.

Details.
Artist: Vanessa Paradis
Title: Be My Baby
Album: Vanessa Paradis
Year: 2001
Genre: French Pop
ResidualImages
In my email, I saw that you asked about the IP address. LyricsPlugin.com changed over to using a PHP content redirector that queries a DNS 'viplyrics.com'. I know when I watch my IP addresses, I saw some 72 addresses instead, for instance. Not sure what's going on in the backend of their site, but i do an HTML body read to find a DIV class, and I've never had any security issues. I downloaded their JSes and found no threats or worrisome redirects aside from what I mentioned.


The program can output to a log file if you use the commandline. I haven't built in the /? switch, but the syntax for command line is "Lyrics.exe", and then optionally you can specify a directory, or individual files. If there are individual files, separate them by spaces, and include the full path to the files in quotes.
(for examples:
C:\downloads\Lyrics.exe Z:\Music Files\
or
Lyrics.exe "D:\Rob Zombie\Dragula.mp3" "D:\Enya\The Celts.mp3"
or even
Lyrics.exe "E:\MP3 Folder"
)

To output a log file, call "lyrics.exe > C:\LyricsLog.txt" or similar, and tell me what the contents of the log file are.

From the error you describe, the Lyrics executable is pulling '0:03:41' as the Song ID3 tag attribute 'Title', and therefore causing this error. I know I always fix the tags first, in MP3Tag, and
then run the Lyrics tool and the import Action

*********UPDATE:
I've now added a /debug switch to the command line interface that will pop up a window of all the file attributes I'm able to retrieve for each file selected or in the directory selected. Obviously, run the Lyrics.exe with the troublesome file, and add the debug switch like so:
Lyrics.exe "C:\Music\Be My Baby.mp3" /debug

Then that array of file attributes will tell me how your particular OS and files are configured and why, as you say in the details, the Title is not being pulled as 'Be My Baby' but instead as '0:03:41'; also, the artist should be 'Vanessa Paradis' not 'French Pop'. We'll get to the bottom of this difference in attributes if you help me! biggrin.gif
DetlevD
QUOTE (ResidualImages @ Nov 6 2010, 12:40) *
... The program can output to a log file if you use the commandline. I haven't built in the /? switch, but the syntax for command line is "Lyrics.exe", and then optionally you can specify a directory, or individual files. If there are individual files, separate them by spaces, and include the full path to the files in quotes. ...
To output a log file, call "lyrics.exe > C:\LyricsLog.txt" or similar, and tell me what the contents of the log file are. ...
I've now added a /debug switch to the command line interface that will pop up a window of all the file attributes I'm able to retrieve for each file selected or in the directory selected. Obviously, run the Lyrics.exe with the troublesome file, and add the debug switch like so:
Lyrics.exe "C:\Music\Be My Baby.mp3" /debug
Then that array of file attributes will tell me how your particular OS and files are configured and why, ...


Well, a remarkable initiative.
Sorry to say that it does not work.
Note:
"http://lyricsplugin.com/" sends only a test page.
"http://www.lyricsplugin.com/" sends only a test page.


I've just downloaded the current version, but it does not work.
--> Note: Do not forget to count up version number 1.0 even for intermediate bug release.

When I did a commandline call ...
lyrics.exe "M:\MUSIK\ROCK\Z\ZZ TOP\1970 - ZZ Top's First Album\01_SomebodyElseBeenShakingYourTree_ZZTOP_ZTFA_1970.mp3" /debug >log.txt

... the /debug switch does nothing.
Redirection to file "log.txt" creates an empty file.
Error message in window: ***** Error retrieving Artist and Title from ''.


When I did this ...
lyrics.exe >log.txt
... and follows the upcoming file open dialog ...
... there came up a window with error message:
" Did NOT find lyrics for '00:02:28' by ."
... there was created a log file output with content:
http://www.lyricsplugin.com/wmplayer03/plugin/?artist=&title=00:02:28

I see no "array of file attributes".

DD.20101106.1446.CET
ResidualImages
I have no control over www.lyricsplugin.com, but yes, I do see it's just an apache test page at the root. try this link to see that the domain is working.

I personally hadn't tried to do both the /debug and > log.txt commands
At 6:30 AM all I had in me was enough brain to make the /debug switch activate if it is the last argument passed in.
I'm a little more awake now, and have edited the file. Latest version is 1.0.0.2, thanks for the reminder to increment.


you should get a window like so:

DetlevD
QUOTE (ResidualImages @ Nov 6 2010, 15:34) *
... I personally hadn't tried to do both the /debug and > log.txt commands ...

You should better work out the usage and syntax description of your tool.

QUOTE (ResidualImages @ Nov 6 2010, 15:34) *
... you should get a window like so: ...

No window.
I've tried version 1.0.0.7, still the same effect, does not work on my Win XP SP3.

I have no problems to get a lyrics text when using a user defined Mp3tag tool:
[#20]
MTTOOLSNAME=LyricsVIP
MTTOOLSPARAM='http://www.google.com/cse?cx\u003d017751158110742404216%3Againppvv-i8&ie\u003dUTF-8&siteurl\u003dwww.lyricsvip.com&q\u003d'$replace(%artist% %title%,' ','+','?','%3F')
MTTOOLSPATH=C:\\Programs\\Internet Explorer\\iexplore.exe
MTTOOLSINST=0

Well, it needs a second click to step from Google to lyricsvip, but it works.

DD.20101107.0311.CET
ResidualImages
I just tried this on a Windows XP SP3 box, by typing "lyrics.exe /debug" and the program prompts for directory or files, I chose directory I knew had an MP3 in it, and the screen popped up with the file attributes of the file in that directory.

Low and behold, the extended info is in different places on XP. Got the 1.0.0.8 version catching Windows versions. If I remember correctly, Vista and 7 are the same as far as their extended info. So now it works on XP and Windows 7.


By the way, I was also able to type:
lyrics.exe" "Z:\(Do You Wanna Date My) Avatar\Do You Wanna Date My Avatar.mp3" /debug > C:\log.txt
and had no issues under XP or 7... I'm terribly confused why you're not getting the window popping up I said you should either with command line or straight folder/file selection.

I would appreciate your continued testing of this now that XP is supported... I realize it's frustrating from your end, but you've helped.

As a side note, I ran this tool on 10,724 MP3s on a network drive today over gigabit switch. Took 8.5 hours to query for every one of those, but all I had to do to start it was click on the 'directories' button and select the root of the network-mapped music drive, and let it run in the background. that kind of ease and use is what I want more than just myself to have!
DetlevD
QUOTE (ResidualImages @ Nov 7 2010, 03:47) *
... By the way, I was also able to type:
lyrics.exe" "Z:\(Do You Wanna Date My) Avatar\Do You Wanna Date My Avatar.mp3" /debug > C:\log.txt
and had no issues under XP or 7... I'm terribly confused why you're not getting the window popping up I said you should either with command line or straight folder/file selection. ...

When calling Lyrics.exe with parameter on the commandline there should not popup a file open oder folder open dialog, right?
See attached screenshot what happened.
Click to view attachment

QUOTE (ResidualImages @ Nov 7 2010, 03:47) *
...
Low and behold, the extended info is in different places on XP. Got the 1.0.0.8 version catching Windows versions. If I remember correctly, Vista and 7 are the same as far as their extended info. So now it works on XP and Windows 7. ...

I do not understand "extended info is in different places".
The artist and title info is in the ID3v2.4 tag within the mp3 file.

DD.20101107.0755.CET
ResidualImages
QUOTE (DetlevD @ Nov 7 2010, 01:55) *
When calling Lyrics.exe with parameter on the commandline there should not popup a file open oder folder open dialog, right?
See attached screenshot what happened.
Click to view attachment


The window always pops up a summary of what happened after running on all files selected or in the directory selected, so that you know song by song if lyrics were found. That is NOT an error. The screenshot you attached is normal.
In your screenshot, you showed me the end result. what popped up before then? the window I said should pop up for the debug should have shown a vertical array of attributes for the file.
like the 'File Properties' window in the image in the earlier post


QUOTE
I do not understand "extended info is in different places".
The artist and title info is in the ID3v2.4 tag within the mp3 file.

I don't pull from the ID3 tag to find the artist and title. I've always been able to use extended file attributes under Windows APIs to find that information on all my systems, and it's worked on other peoples' systems too. That's an array of values returned, with different indexes for the same info. the 'File properties' above is from Windows 7, this is from XP:



Please tell me
1) if you ever see the 'File Properties' array Window when using on the command line with the
/debug switch
2) Just for grins, try lyrics.exe O:\test\t1\ and tell me what happens.
3) Either that, or you could always try to use this tool in MP3tag.exe with the 'Tool' settings mentioned in the original post.

The command line is there to just make scripting people happy, it's not actually necessary for you to use it, or even for you to know about it aside from the fact that you're helping test it. The GUI and MP3tag integration do just fine for most things. I want to see it working on a directory with multiple files on your system if you could. It doesn't change any files, just creates txt files from which an 'Action' in MP3tag can import.

Since a picture is worth a thousand words, I'm attaching screenshots under XP and using MP3Tag 2.46a. This is the order things should appear when using under MP3Tag.exe:

http://sites.google.com/site/droidburke/1.jpg
http://sites.google.com/site/droidburke/2.jpg
http://sites.google.com/site/droidburke/3.jpg
dano
Windows doesn't support ID3v2.4 that's why your tool doesn't get artist/title info.
Mike_nl
Why do you need to read the Tags ? That is the thing what Mp3tag does brilliantly!

Just change the parameters instead of %_folderpath% to %artist% %title%.

Or am I missing something here ?


Edit 18:39 Spelling Mistake
DetlevD
I changed the test case a bit.
Now using a ID3v2.3 UTF-16 encoded mp3 file, which properties can be seen in the explorer properties sheet.

I let run Lyrics.exe with parameter and option /debug from the command line.
There is no debug window popping up.
But I am not totally sure, because there is a short screen flicker, which could indicate, that there might be a window opened but closed immediately.
Result state see screenshot attached.
Click to view attachment

QUOTE (ResidualImages @ Nov 7 2010, 09:34) *
The window always pops up a summary of what happened after running on all files selected or in the directory selected, so that you know song by song if lyrics were found. That is NOT an error. The screenshot you attached is normal. ...

Beside the fact, that it is reporting a failure state.

QUOTE (ResidualImages @ Nov 7 2010, 09:34) *
... In your screenshot, you showed me the end result. what popped up before then? the window I said should pop up for the debug should have shown a vertical array of attributes for the file.
like the 'File Properties' window in the image in the earlier post ...

There is no debug window popping up.

QUOTE (ResidualImages @ Nov 7 2010, 09:34) *
... I don't pull from the ID3 tag to find the artist and title. I've always been able to use extended file attributes under Windows APIs to find that information on all my systems, and it's worked on other peoples' systems too. ...

Sorry to say, it works not here.

QUOTE (ResidualImages @ Nov 7 2010, 09:34) *
...
Please tell me
1) if you ever see the 'File Properties' array Window when using on the command line with the
/debug switch
2) Just for grins, try lyrics.exe O:\test\t1\ and tell me what happens.
3) Either that, or you could always try to use this tool in MP3tag.exe with the 'Tool' settings mentioned in the original post. ...

Hmm, I do not want to blow up the test case. I like to keep the test case small and clear.
If it works on the commandline with one file, then it will work with all files, even when invoking the tool from within other applications.

Additional question:
Is the Lyrics.exe tool able to work on systems without Internet Explorer installed?

DD.20101107.1437.CET
DetlevD
QUOTE (Mike_nl @ Nov 7 2010, 12:33) *
Why do you need to read the Tags ? That is the thing what Mp3tag does brilliantly!
Just change the parameters instead of %_folderpath% to %artist% %title%. ...

Good point!!!!!

DD.20101107.1427.CET
ResidualImages
QUOTE
Windows doesn't support ID3v2.4 that's why your tool doesn't get artist/title info.

Explain to me why it works on every system I've tried stateside. I've been using MP3s with mainly ID3v2.3 UDF-16. Windows explorer will show the details of each song under detailed view settings.
What's the benefit of ID3v2.4? And I'm going to try that just now, be right back.


QUOTE
Why do you need to read the Tags ? That is the thing what Mp3tag does brilliantly!

Just change the parameters instead of %_folderpath% to %artist% %title%.

Or am I missing something here


The whole point of my tool is that it doesn't need MP3Tag to do its work, but it makes for easy import while using MP3Tag. The limitations of MP3Tag needing to 'Run on every file' or just passing one more general parameter makes it annoying. My first version two years ago opened up a process for each and every song selected; if you selected 50 songs, it spawned 50 processes [run for each file was checked in MP3Tag's Tools]. If you can show me how to configure a tool in MP3tag that will pass in every 'artist|title' of each selected song as a single chunk parameter to a single executable, we can leverage MP3tag to do the work that it does do very well indeed! something like for each song in selection{ %artist%|%title%|}next that doesn't open 50 processes all at once. I'd even settle for it opening 1 process 50 times, though I tried to design this tool to open once, and handle single files or directories or multiple files all seamlessly. Again, the pain of it not working on your side of the ocean... it's incredibly odd and frustrating.

The pain of having to do songs 1 by 1 is the slow, annoying part. this is supposed to bypass that and let you do whole directories, and the directories within that directory. Like I said yesterday, I opened this tool, no MP3Tag.exe running, told it the root of my network music mapped drive, and let it run for 8.5 hours all by itself. So a total of 3 clicks made it find lyrics, if they existed on the site I'm using, to 10,724 songs and store them as individual text files in the same folder as the MP3 file they represented. Then I started MP3Tag.exe, and in my 'Standard' action, I say to try to import UNSYNCEDLYRICS from %_filename%.txt.

QUOTE
Additional question:
Is the Lyrics.exe tool able to work on systems without Internet Explorer installed?


Lyrics.exe opens an invisible Internet Explorer page to retrieve the data. Just like lyricsplugin.com's windows media player plugin, this tool relies on Internet Explorer and windows media player to be installed. Perhaps that's what's causing the hangup. Do you people having the problems use the EU version of XP (sorry, American here, we have no windows shipping without internet explorer and wmp)?


QUOTE
I let run Lyrics.exe with parameter and option /debug from the command line.
There is no debug window popping up.
But I am not totally sure, because there is a short screen flicker, which could indicate, that there might be a window opened but closed immediately.
Result state see screenshot attached.

The screenshot you showed shows the issue. Your Windows XP is not retrieving the extra info, like so:


The only way to get this tool to work for people who's Windows doesn't tell them the information about their music files natively is if someone can tell me how to pass a list of every selected file's 'title|artist' on as one argument in the 'Tools' section.
To get this straight, one last time... If you guys set your type of folder view to 'Music' under the customize tab of folder properties in Windows Explorer, you can't then view in Details mode for that folder and see these columns:

???

That boggles my mind. I'm going to have to break out my MSDN's European versions of XP if that is seriously the case.
DetlevD
QUOTE (ResidualImages @ Nov 7 2010, 16:56) *
... if someone can tell me how to pass a list of every selected file's 'title|artist' on as one argument in the 'Tools' section. ...

Try to implement something like Winamp's option /ADD.
Try to implement some queue manegement.
Try to make your app sensible for a second starting/running process of itself, fetch the parameter from the app's commandline, put it into a queue list and kill the second process.

DD.20101107.1715.CET
ResidualImages
So I just changed to ID3v2.4 lyrics under my XP, SP3 box.
My Windows XP STILL natively pulls all the information, lets you sort detailed view on track, title, artist, album, length, whatever.

If the only differences are that you guys have a version of Windows that comes without Internet Explorer or WMP or some other setting, and for some reason you can't have a detailed view of Music-settings folders sortable by all those columns I natively have, then I at least understand why my tool isn't working for you. I do NOT understand why you can't have the detailed view with the same columns, but that would be why the tool fails. So you cannot make Windows do natively what I've attached below?

Also, I see some of you using MP3Tag 2.46d. I'm using 2.46a. Is there a difference in how it writes the ID3v2.4 tags?

I may make a test exe later today that attempts to read the title and artist a different way, without caring about lyrics or anything, and tell you what it found. But I'm assuming most of you are tired of dealing with this tongue.gif

dano
You also have ID3v1 tags, it will read these.
ResidualImages
QUOTE (DetlevD @ Nov 7 2010, 11:15) *
Try to implement something like Winamp's option /ADD.
Try to implement some queue manegement.
Try to make your app sensible for a second starting/running process of itself, fetch the parameter from the app's commandline, put it into a queue list and kill the second process.

DD.20101107.1715.CET

I cannot see the benefit of starting 10,724 processes at once, even if 10,723 of them just add their parameters to the queue and then kill themselves. 1 Process can and does handle this. All I'm trying to hash out is to make a way for my Euro friends there to retrieve the title and artist of each song in a directory or each song passed in. The version from 2 years ago DID do more like what you were saying, eventually, calling upon ProcessesRunning and querying whether it was the first or a second instance, and then pooling all the information. It was SLOOOOOOW for more than 20, 40, 60 files maximum.

Do you know of a way MP3tag.exe can be told to 'Run on each file selected' but do them one at at time?
ResidualImages
QUOTE (dano @ Nov 7 2010, 11:23) *
You also have ID3v1 tags, it will read these.

so you guys don't embed all lower versions? Now I understand!
Thanks Dano!!!!!!! my head can stop hitting the brick wall.

if I may ask... what's the benefit to not having ID3v1 tags up through ID3v2?
DetlevD
QUOTE (ResidualImages @ Nov 7 2010, 17:24) *
I cannot see the benefit of starting 10,724 processes at once, even if 10,723 of them just add their parameters to the queue and then kill themselves. 1 Process can and does handle this. All I'm trying to hash out is to make a way for my Euro friends there to retrieve the title and artist of each song in a directory or each song passed in. The version from 2 years ago DID do more like what you were saying, eventually, calling upon ProcessesRunning and querying whether it was the first or a second instance, and then pooling all the information. It was SLOOOOOOW for more than 20, 40, 60 files maximum.

Do you know of a way MP3tag.exe can be told to 'Run on each file selected' but do them one at at time?

Hmm, I can collect all data given as parameters in the commandline of a cmd batch file into one text file - for all selected files - from within Mp3tag.

Usage description from my "collect.cmd" file:
REM Usage:
REM Collect all parameters from the commandline of this batch command file into an external text list file.
REM Afterwards the external text list file can be used as input file for an external application, which can be called from within this batch command file.
REM
REM When using option /C each call of this batch command file creates a new line in the external text list file.
REM When using option /R an external application will be called using the externsl text list file.
REM When using option /L the content of externsl text list file will be displayed to console out.
REM When using option /D the external text list file will be deleted.
REM ©20100926.Detlev Dalitz.


Well, I've tested this with a list of 100 files but not with a list of 10000 files.
Mp3tag pumps out the data as far as possible (depends on the batch file).
It was just a study how to overcome Mp3tag's limited "run external app" feature.

If Florian could implement better support for running external applications, life would be much easier.
For example:
Run( program-name, parameters )
Runs a program as a normal window.

RunHide( program-name, parameters )
Runs a program as a hidden window.

RunHideWait( program-name, parameters )
Runs a program in a hidden window and waits for it to close.

RunIcon( program-name, parameters )
Runs a program as an icon.

RunIconWait( program-name, parameters )
Runs a program as an icon and waits for it to close.

RunShell( program-name, params, directory, displaymode, waitflag )
An advanced form of the Run function that even allows the specification of a working directory, along with the window view mode and whether or not to wait for completion of the run program in a single function.

RunWait( program-name, parameters )
Runs a program as a normal window and waits for it to close.

RunZoom( program-name, parameters )
Runs a program in a maximized window.

RunZoomWait( program-name, parameters )
Runs a program in a maximized window and waits for it to close.

ShellExecute ( program-name, params, directory, display mode, operation )
Runs a program via the Windows ShellExecute command.

Most important is to have a "wait" option.

DD.20101107.1758.CET
ResidualImages
Very large changes to create a good solution for us all.
Version .10 includes new instructions.

Basically, you need an 'Export for Lyrics' action that exports currently selected songs from MP3Tag. The export's MTE file should read:
$filename(txt,utf-8)$loop(%_path%)%_path%|%artist%|%title%
$loopend()


Secondly, the Export File Name parameter of the Export for Lyrics action is now used as the Parameter for the Lyrics Tool under MP3Tag

The zip includes a PDF explaining how to set it up from scratch, but you testers probably can figure it out from the info above.

I appreciate all your patience and hard work and time. This has been an incredible bit of stubbornness on all our parts to get it working.

That being said, I think I shall cry if you can't get it to work this time. tongue.gif
(for about 3 minutes, the wrong zip file was uploaded. if you downloaded the link earlier than this post I'm creating right now, re-download)
DetlevD
QUOTE (ResidualImages @ Nov 7 2010, 20:31) *
... I appreciate all your patience and hard work and time. ... That being said, I think I shall cry if you can't get it to work this time. tongue.gif

Stay calm, do not worry, no need to cry.

Offered download version 1.0.0.11 seems to be internally version 1.0.0.10.
Please make the version number obvious on the user interface.

This 3-step version works for me!

Additionally I would like to have the choice to put the incoming text files into a subfolder within the current folder (or freely into some folder anywhere in the system), to be controlled by cmdline parameter or ini file.

DD.20101108.1221.CET
ResidualImages
QUOTE (DetlevD @ Nov 8 2010, 06:21) *
Stay calm, do not worry, no need to cry.

I'm going to quit sniffling now. wink.gif

QUOTE
Offered download version 1.0.0.11 seems to be internally version 1.0.0.10.
Please make the version number obvious on the user interface.

I'll work on version display after work today. When I download the zip, and look at the properties, the version does say 1.0.0.11.
Interesting babbling that isn't very important:
1.0.0.10 is the same as .11, except for a progress bar being shown while reading the Exported file. I tried .10 on 500+ files to see the speed, and I noticed that reading 500+ lines from the export file took a handful of seconds in which nothing was displayed, which made me wonder for a couple seconds whether or not it had locked up. then the progress bar about obtaining the lyrics popped up magically, and I figured out it hadn't locked up, it had just taken a few seconds to read that exported text file. consequently, the .11 shows a progress of reading the export file.

QUOTE
This 3-step version works for me!

That's what I'm talking about! Now that it worked for you, we've got some more interesting things to talk about, like changes. smile.gif

QUOTE
Additionally I would like to have the choice to put the incoming text files into a subfolder within the current folder (or freely into some folder anywhere in the system), to be controlled by cmdline parameter or ini file.

Picky picky picky haha. I'll roll it around in my head and come up with some ideas to try this evening.
DetlevD
QUOTE (ResidualImages @ Nov 8 2010, 13:59) *
... I tried .10 on 500+ files to see the speed, ...

Watch out to torture the server not to much.
Code some random time delay here and there into your script.

DD.20101108.1545.CET
lexs
Hi,

I tried to install and run this beautiful tool as explained. Everything works as expected, except for one crucial point:

For every song that lyrics are found for, the lyrics are the same:

Upgrade to Lyrics Plugin version 0.4

I tried inspecting the intermediate results. It turns out the second step (running lyrics.exe) actually creates a txt file for every song. But instead of the song's lyrics, the file contains this text above.

Since this works apearantly for you all, I wonder: WHAT AM I DOING WRONG?
ResidualImages
Well, apparently the people have changed their website. I will take a look at it this weekend and try to fix it for us.

Thanks for letting me know, and I'm sorry it's not working yet smile.gif


QUOTE (lexs @ Feb 4 2011, 03:58) *
Hi,

I tried to install and run this beautiful tool as explained. Everything works as expected, except for one crucial point:

For every song that lyrics are found for, the lyrics are the same:

Upgrade to Lyrics Plugin version 0.4

I tried inspecting the intermediate results. It turns out the second step (running lyrics.exe) actually creates a txt file for every song. But instead of the song's lyrics, the file contains this text above.

Since this works apearantly for you all, I wonder: WHAT AM I DOING WRONG?

ResidualImages
They've changed the php and JS behind the scenes indeed! Appears like that just happened in January.
ResidualImages
QUOTE (lexs @ Feb 4 2011, 02:58) *
Hi,

I tried to install and run this beautiful tool as explained. Everything works as expected, except for one crucial point:

For every song that lyrics are found for, the lyrics are the same:

Upgrade to Lyrics Plugin version 0.4

I tried inspecting the intermediate results. It turns out the second step (running lyrics.exe) actually creates a txt file for every song. But instead of the song's lyrics, the file contains this text above.

Since this works apearantly for you all, I wonder: WHAT AM I DOING WRONG?




Well, I was tired of not having this tool. I currently have a new tool that does not rely on LyricsPlugin.com, but instead Googles the song and artist, and if it finds MetroLyrics, AZLyrics, Sing365, LyricsMania, LyricsMode, or SongLyrics results in the first page of Google results, it will attempt to parse the lyrics from those sites.

Does anyone have any other recommended sites?

I will be polishing up the tool and documenting the options this week.
ResidualImages
After looking it over LyricsWiki (http://lyrics.wikia.com/) seems to have a fairly reliable database. So I am updating the tool to use that site.

I could release modules at a later version that picked up from other sites if LyricsWiki is not doing the trick for your music.

Original Post will be updated.
Luctus
QUOTE (ResidualImages @ Nov 8 2011, 00:11) *
Well, I was tired of not having this tool. I currently have a new tool that does not rely on LyricsPlugin.com, but instead Googles the song and artist, and if it finds MetroLyrics, AZLyrics, Sing365, LyricsMania, LyricsMode, or SongLyrics results in the first page of Google results, it will attempt to parse the lyrics from those sites.

Does anyone have any other recommended sites?

I will be polishing up the tool and documenting the options this week.


darklyrics.com
ResidualImages
QUOTE (Luctus @ Nov 27 2011, 05:35) *
darklyrics.com



well, that can be arranged. though the site is certainly slow and inconsistent, today. making coding for it difficult.

Complete. See original post.
LyricsLover
Nice work! Thank you for this tool!! walkman.gif

I have some questions:
a ) How can I save the lyrics to a specific path (not the same where the mp3 are stored)?
Example:
I would like to store the lyrics for the 10cc-song '01 - The Wall Street Shuffle' in the path
D:\mp3\Lyrics\1\10cc (01 - The Wall Street Shuffle).txt
(First letter/number of the Band as directory name, no need for the source in the filename)

If this is too complex, I would just be happy with a fixed different lyrics path like:
D:\mp3\Lyrics\AllFoundLyrics\


b ) How can I run the lyrics.exe without the final result windows?
Just the logfile or nothing at all would be enough for me.


c ) How can I export only the files not alread including lyrics? The command in the PDF
QUELLTEXT
$filename(txt,utf-8)$loop(%_path%)%_path%|%artist%|%title%
$loopend()
exports ALL files, not only the one without lyrics, right?


d) Is there any known limit of number of tracks to get the lyrics? Are the sources banning my IP if I use your tool to many times?
ResidualImages
QUOTE (LyricsLover @ Mar 3 2012, 07:44) *
Nice work! Thank you for this tool!! walkman.gif
Glad you like! smile.gif

I have some questions:
a ) How can I save the lyrics to a specific path (not the same where the mp3 are stored)?
...
If this is too complex, I would just be happy with a fixed different lyrics path like:
D:\mp3\Lyrics\AllFoundLyrics\
this is a likely option, I suppose. i understand liking options, but do people hang on to the ".txt" files once they embed the lyrics?? i don't usually; that's why I never made many options for the output files

b ) How can I run the lyrics.exe without the final result windows?
Just the logfile or nothing at all would be enough for me.
I will try to remember to include a no-result option next time I compile it

c ) How can I export only the files not alread including lyrics? The command in the PDF
CODE
$filename(txt,utf-8)$loop(%_path%)%_path%|%artist%|%title%
$loopend()
exports ALL files, not only the one without lyrics, right?
correct. i can look to see if there is any clean way to list only non-lyric'd files, but I will be at the mercy of what is possible in the code section.

d) Is there any known limit of number of tracks to get the lyrics? Are the sources banning my IP if I use your tool to many times?
the tool is actually visiting the websites in the background, so their terms are not being violated. they still get hits / generate ads, whatever. i have run this on thousands of files multiple times and never had issues.

tbum20
QUOTE (LyricsLover @ Mar 3 2012, 15:44) *
c ) How can I export only the files not alread including lyrics? The command in the PDF
CODE
$filename(txt,utf-8)$loop(%_path%)%_path%|%artist%|%title%
$loopend()
exports ALL files, not only the one without lyrics, right?


I don't feel this should be included in the hard code of the tool as the core of the tool would then include a rule based on code which is highly dynamic. Most importantly there currently are two tags for lyrics which are universally considered standard not to mention the tag for lyrics is moderately inconsistent between applications.

LyricsLover,
To run the tool for songs without lyrics you should create a column in mp3tag with the tag(s) mapped to lyrics and simply sort your files by that column making it very simple to choose songs without lyrics.
All files would already have to be loaded into mp3tag for a rule change in the lyrics tool even be applicable and creating a column to sort your files would complicate your experience using this tool very little.
ohrenkino
ZITAT(tbum20 @ Mar 12 2012, 02:04) *
... you should create a column in mp3tag with the tag(s) mapped to lyrics and simply sort your files by that column making it very simple to choose songs without lyrics..

Or apply a filter with something like
%unsyncedlyrics% IS ""
as this works even if there is no column displayed with that data.
ResidualImages
Thanks, tbum20 and ohrenkino for chiming in.

both of you have fine ideas. perhaps one of those pieces of advice will work out better for LyricsLover
LyricsLover
ZITAT(ResidualImages @ Mar 14 2012, 00:04) *
...perhaps one of those pieces of advice will work out better for LyricsLover
Yes. For c) ohrenkino's
QUELLTEXT
%unsyncedlyrics% IS ""
is a nice solution!

Now I hope for a solution for a ) and b ). For a big song collection it would be nice to have the lyric files in one single directory, not everywhere on the disks. The same for b ): If you search the lyrics for a huge amount of songs, the result- and final window isn't that interesting .-)
ResidualImages
QUOTE (LyricsLover @ Mar 13 2012, 23:17) *
Yes. For c) ohrenkino's
CODE
%unsyncedlyrics% IS ""
is a nice solution!

Now I hope for a solution for a ) and b ). For a big song collection it would be nice to have the lyric files in one single directory, not everywhere on the disks. The same for b ): If you search the lyrics for a huge amount of songs, the result- and final window isn't that interesting .-)


glad you liked one of their solutions.

I am on call this week at work, so I'm getting sleep when I can. hopefully next week I'll be able to create some extra options as far as file paths and results window for you; I may just make a special LyricsLover version especially for you! because otherwise, I want to keep it the way it is for me. wink.gif
LyricsLover
A special version only for me? w00t.gif Wow!
I really hope that other users appeciate this features too. cool.gif
ResidualImages
QUOTE (LyricsLover @ Mar 15 2012, 03:00) *
A special version only for me? w00t.gif Wow!
I really hope that other users appeciate this features too. cool.gif



haha, alright, i'll try to wrap it up next week.
soehest
I like this tool but it seems to be choking for me on large collections:

I am getting this error (attached as screenshot every time i run it on my music folder 4000+ files)

Best Regards
Click to view attachment
ResidualImages
QUOTE (soehest @ Mar 18 2012, 18:25) *
I like this tool but it seems to be choking for me on large collections:

I am getting this error (attached as screenshot every time i run it on my music folder 4000+ files)

Best Regards
Click to view attachment


Exciting! I'll look into that error this week as well. something specific about what you're doing has exposed a flaw in my code somewhere.

Thank you; if I can't track it down, I may ask a question or two of you. But that type of error is usually fixed by correcting some dumb line I overlooked.

Glad you like it, now let's get rid of that error tongue.gif
soehest
Oh no new issue biggrin.gif

Getting this on some songs:

Unfortunately, we are not licensed to display the full lyrics for this song at the moment. Hopefully we will be able to in the future. Until then, how about a random page?
[I want to edit metadata]

There needs to be a check to stop downloading those lyrics as they are not complete. I have no clue to what criteria sets this off.
ResidualImages
QUOTE (soehest @ Mar 19 2012, 11:00) *
Oh no new issue biggrin.gif

Getting this on some songs:

Unfortunately, we are not licensed to display the full lyrics for this song at the moment. Hopefully we will be able to in the future. Until then, how about a random page?
[I want to edit metadata]

There needs to be a check to stop downloading those lyrics as they are not complete. I have no clue to what criteria sets this off.


good job, haha. I know that's possible to happen, but I had never seen it actually happen. I'll put a check in there for that.
soehest
QUOTE (ResidualImages @ Mar 19 2012, 17:02) *
good job, haha. I know that's possible to happen, but I had never seen it actually happen. I'll put a check in there for that.


Hehe i find the odd bugs ;-) There is an example here to help you test:
http://lyrics.wikia.com/Tool:Intolerance

:-)
This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.
Invision Power Board © 2001-2014 Invision Power Services, Inc.