Help - Search - Members - Calendar
Full Version: [WS] Discogs ALL
Mp3tag Forums > Mp3tag - International > Development > Web Sources Scripts
Pages: 1, 2, 3, 4, 5
Pufas
OK,
I made this script long long time ago (~2 years or so), i never thought about publishing it but i find it very useful for me, so I decided to do it. I'm not a coder and I made it long time ago, so don't expect me fixing bugs or updating it. However it's pretty much complete (at least how I imagined it) and it works just fine for me.
EDIT: I change my mind, I will try to develop it further.

The idea was to tag & rename large amounts of full releases (ablums, vinyls, ect.), extracting as much information as possible.

Fills these tags:
CODE
BAND
BANDNAMEVARIATION
ARTIST
ARTISTNAMEVARIATION
ALBUM
TITLE
TRACK
VINYLNUMBER
TOTALTRACKS
DISCNUMBER
DISKNAME
TOTALDISCS / TOTALVINYLS
MEDIATYPE
RELEASETYPE
PUBLISHER
CATALOG
GENRE
STYLE
COUNTRY
YEAR (year only)
RELEASEDATE (full date)
RELEASETIME (not formated)
COMPILATION (Yes/No)
MIXARTIST (Remix)
COMPOSER
CREDITS
WWW
DISCOGSID
MASTERID

Renames directory and files to something like
CODE
[CAT 001] Album Artist - Album (YEAR)
    00 Album Artist - Album (YEAR).m3u
    00 Album Artist - Album (YEAR).sfv
    00 Album Artist - Album (YEAR).txt
    A Track 1.mp3
    B Track 2.mp3

For Various Artist releases:
CODE
[CAT 001] Album Artist - Album (YEAR)
    00 Album Artist - Album (YEAR).m3u
    00 Album Artist - Album (YEAR).sfv
    00 Album Artist - Album (YEAR).txt
    01 Artist 1 - Track 1.mp3
    02 Artist 2 - Track 2.mp3

This script has a lot of fixes for discogs and extras, so that all you tags and files look alike.

How to use it?
1. Find your release at www.discogs.com.
2. Copy it's id (i.e. http://www.discogs.com/Age-Of-Love-The-Age.../release/116283, you need 116283).
3. Drop your files to Mp3tag.
4. Delete all present tags (Not necessary anymore)
5. Run "Tag sources -> Discogs_xml_all"
6. Paste id (search field sould be like this 116283)
7. Aplly tags.
8. Run actions:
1. Discogs_XML *NEEDED* to complete tagging, run this first, put it at the top of the actions list.
2. MixedCD check this *ONLY* if you have CD ripped to a single track, otherwise it will mess up your tags.
3. RenameLabels rename your files, folder, export .m3u playlist, .sfv checksum and txt release info. If you will uncheck it your files will be tagged, but not renamed, moved, no info exported and ect.
NOTE: Script will move your tagged files' dir to E:\Music\_labels\%PUBLISHER% (that's where i store my music). If you do not want that delete last command line in Actions --> 3. RenameLabels, or change dir to which one suits you better.

CODE
CHANGES in v2.09:
FIX: Credits fix.

CHANGES in v2.08:
FIX: More code fix.

CHANGES in v2.07:
FIX: Issues related to renewed Discogs API.
ADD: New field - MASTERID.

CHANGES in v2.06:
FIX: Small track numbering issue.

CHANGES in v2.05:
ADD: New field - RELEASETIME.
FIX: Tracklisting issues.
CHANGE: improved text export,also .nfo instead of .txt.

CHANGES in v2.04:
FIX: DISCNAME bug.
FIX: Minor NOTES issues.
FIX: Improved TOTALTRACKS obtaining method.

CHANGES in v2.03:
FIX: DISCNUMBER issues.
ADD: New field - WWW with link to discogs.
ADD: Now you can run actions more than once.

CHANGES in v2.02:
CHANGE: CREDITS now is sorted by role (just like in discogs).
CHANGE: Removed artist name variations from CREDITS.
ADD: COMPOSER tag, filled from Composer, Written By,
Music By and Producer.
FIX: A lot track fixes.

CHANGES in v2.01:
ADD: Removes Dupe PUBLISHER and CATALOG values.
ADD: Grabs all genres instead if first one.
ADD: If DJ mix is present, it is written to BAND tag.
ADD: Overall credits are separated from per track credits.
FIX: Now TRACK, TOTALTRACKS, NOTES, COUNTRY, MIXARTIST
should work fine.
FIX: More minor fixes.

CHANGES in v2.00:
CHANGE: Now you can run actions only once after applying tag
from web source.
CHANCE: All credits go to CREDITS tag, also Remix credit goes
to MIXARTIST tag.
CHANGE: Script should run *a lot* faster.
ADD: Added name variations.

CHANGES in v1.23:
ADD: New tags - SONGWRITER, CELLO, MELODICA, SAXOPHONE, VIOLA, VIOLIN.

CHANGES in v1.22:
ADD: New tags - LEADER, ORGAN, TECHNICIAN
FIX: RELEASETYPE issues.
FIX: There was per track credits bug.

CHANGES in v1.21:
ADD: Removes up to five dupe tag values like 2x same label,
catalog or credits artist.
FIX: Minor bugs.

CHANGES in v1.20:
FIX: More credits issues.
FIX: Minor NOTES fix.
ADD: New tags - CHOIR, DIRECTED, BASS, CONCERTMASTER, DRUMS,
ACCORDION, GUITAR, PERCUSSION, STRINGS, TRUMPET, FLUTE,
ADAPTED, ENSEMBLE, PIANO, MUSIC, SYNTHESIZER, THANKS.

CHANGES in v1.19:
FIX: "Empty fields" bug. Script did not work with releases
that had empty date, country or style.

CHANGES in v1.18:
FIX: More minor fixes.
CHANGE: TOTALTRACKS field now supports up to 9CDs releases (was 2CDs).
ADD: New tag - DISCNAME.

CHANGES in v1.17:
FIX: NOTES formating.
ADD: New tag - COMPILATION [Yes/No]
CHANGE: m3u, sfv and txt filenames.

CHANGES in v1.16:
FIX: More credits issues.
ADD: New tag - NOTES.
CHANGE: Improved cover art fetching.

CHANGES in v1.15:
FIX: Credits issues.
ADD: TOTALTRACKS for vinyls.

CHANGES in v1.14:
FIX: Credits issues.
ADD: New tag - TOTALVINYLS.

CHANGES in v1.13:
FIX: There was some errors, but now it seem works fine.

CHANGES in v1.12:
FIX: Track number issues.

CHANGES in v1.11:
ADD: Cover Art Support.
ADD: New fields added: VINYLNUMBER, KEYBOARDS, ARTWORK, PHOTOGRAPHY.

CHANGES in v1.10:
FIX: Now saves all credits, including "overall". There was error in actions.
FIX: Properly saves tags witch includes named vinyl or disk sides like this.
FIX: Did not fixed artist names from "Artist, The" to "The Artist" witch
included "(#)" at the end, like this one.
ADD: You can leave your curent tags, script should auto-remove them.
ADD: Auto exports .m3u playlist, .sfv checksum and .txt release info.
ADD: Auto move to dir where i store files.
CHANGE: Underdashes "_" replaced with spaces.

v1.00:
First public version.

That's it. I've put a lot of hard work into it. I hope you like it.
Feel free to modify it for your needs.
Also if you need any help, just ask.
Andromedych
Dear Pufas! Thanks a lot for Your great script. It has great possibilities. But I would like to know, how can I correct these lines when I get info from discogs

If in page of discogs I see:
"Producer, Written-By - Markus Boehme , Martin Hensing"

but after using Your script it returns lines like this:

By</role><name>Markus Boehme</name><role>Producer</role><role>Written By</role><name>Martin Hensing</name>

How can I correct Your script to get needed line "Producer, Written-By - Markus Boehme , Martin Hensing" copied to COMPOSER line?

Also, Your script doesn't get an ARTWORK from discogs. How can I add it or can you improve it?

Thank You
Aythamie
Hi, I'tje getting an error when it tries to load the DISCNUMBER.

Anyone esle having this problem?
morrison
Thanks for you work Pufas, very impressive script

QUOTE (Andromedych @ Aug 22 2009, 14:01) *
Also, Your script doesn't get an ARTWORK from discogs. How can I add it or can you improve it?

Thank You


You can try add this code after # DISCOGSID section (next line after sayuntil "\"" ):

CODE
# Coverurl
outputto "coverurl"
findinline "\">"
if "<images>"
    findinline "uri=\""
    sayuntil "\" uri"
    findinline "</images>"
endif


UPDATE: more correct code
Windjammer
Dear Forum,

Agree with previous speakers that this is an amazing script rivaling Dano's masterpieces over the years. It's tragic it's not developed anymore. After the big Discogs Upgrade of their site I have 3 things not working

- Overall Credits don't come out at all
- Track Credits come out like this <role>Cello</role><name>Matt McGeever</name>
- After adding the small Cover Art piece of the script I get a pic, but the wrong one

Anyone proficient enough to dig in to this scrip to see if it's fixable?

//Windjammer
morrison
I think I fixed most errors. Except for Credits (other) and regex action, unfortunately.
I share the result if it is interesting community. I need a little more time to fine-tuning.
Pufas script really very cool

QUOTE (Windjammer @ Oct 2 2009, 02:17) *
- Track Credits come out like this <role>Cello</role><name>Matt McGeever</name>


I think you can use replace action for clean it.

replace CREDITS PER TRACK "</role><name>" by ";"
replace CREDITS PER TRACK "</name><role>" by ", "
replace CREDITS PER TRACK "<role>" by ""
replace CREDITS PER TRACK "</name>" by ""
morrison
test version in attach

I will replace some field and explain it later..

UPD: and actions file (use after script)
Windjammer
Great work morrison! Really like what you have done so far with the ID Search dialogue, the Cover Image and solving the LP problem with track numbers using letters (and not numbers).

Discovered that Dano's "Discogs by Release ID Extended"script (attached) brings in the Track Credits just fine. The original brought it into the "MixArtist"-field and I have changed that to bring it into the "Comments"-field instead which suits me better. I also placed the "Track Temp"-field in a "VinylNr."-field instead.

The structure of the script file seems to be very different than the one from Pufas so I don't know how much you can use, but since you seem to know more about scripting than me... The thing I haven't found anything to bring in to mp3tag is Over All Credits.

//Windjammer

2009-10-05
Edited the "Track Temp"-field name again in Dano's script and called it "Vinyl Track" instead, like in the Pufas script.
morrison
Thanks for reply Windjammer, I will try do something with credits later
Pufas
Wow. When I posted this script I never imagined people fix bugs and improve this script, so i "abandoned" this post. I see there is some progress here so maybe I will continue developing this script after all.

EDIT: I edited first post, read it for more info.
Windjammer
Pufas,

Absolutely fantastic that you changed your mind! I cannot find your updated script? The .SRC file is still dated 2009-07-20 and the link to the ZIP above says 1.00...
Pufas
QUOTE (Windjammer @ Oct 17 2009, 13:08) *
Pufas,

Absolutely fantastic that you changed your mind! I cannot find your updated script? The .SRC file is still dated 2009-07-20 and the link to the ZIP above says 1.00...


Sorry, by mistake I've reuploaded old script. Try now. And remember you HAVE to run Discogs_XML action to complete tagging!
Innuendo
QUOTE (Pufas @ Oct 17 2009, 11:39) *
Sorry, by mistake I've reuploaded old script. Try now. And remember you HAVE to run Discogs_XML action to complete tagging!


This looks very, very nice. Thank you for your hard work.

The only two things that seem to be glaring omissions is that the script doesn't seem to grab album artwork & for the tracks I have tested the script on the track list window is empty so I can't move my selected track up and down to make sure it gets tagged properly, i.e. I had run the script against a song that was track 6 on the CD and there was no way to make the script understand it was not track 1.

Again, thank you for your work on this. It's obvious it was not an easy task.
Pufas
QUOTE (Innuendo @ Oct 18 2009, 00:17) *
This looks very, very nice. Thank you for your hard work.

The only two things that seem to be glaring omissions is that the script doesn't seem to grab album artwork & for the tracks I have tested the script on the track list window is empty so I can't move my selected track up and down to make sure it gets tagged properly, i.e. I had run the script against a song that was track 6 on the CD and there was no way to make the script understand it was not track 1.

Again, thank you for your work on this. It's obvious it was not an easy task.


1. Personaly I don't like storing art data inside mp3, but since a lot of users does, I will add it.
2. About that mess with tracknumbers: this was caused by saving tracknumber tag. It looks like mp3tag does not like that, and prefers counting files by himself. I guess I'll have to move vinyl track numbers to some other tag.

As soon as I'm done fixing I will upload new version.
Pufas
I added cover grab, but fixing tracklist is a real headache. I keep getting very unexpected results while trying to tag this:
CODE
Total output:
output["CurrentUrl"]= "http://www.discogs.com/release/2796?f=xml&api_key=1e48c7f4e4"
output["CurrentPreview"]= "http://www.discogs.com/release/2796?f=xml&api_key=1e48c7f4e4"
output["Output"]= ""
output["DISCOGSID"]= "2796"
output["COVERURL"]= "http://www.discogs.com/image/R-2796-1144684772.jpeg"
output["BAND"]= "CJ Bolland"
output["ALBUM"]= "DJ-Kicks"
output["CATALOG"]= "!K7038CD"
output["PUBLISHER"]= "Studio !K7"
output["TOTALDISCS"]= "1"
output["NOTES"]= ""
output["TOTALTRACKS"]= "15"
output["MEDIATYPE"]= "CD"
output["RELEASETYPE"]= "Compilation, Mixed"
output["GENRE"]= "Electronic"
output["STYLE"]= "Techno, Acid"
output["COUNTRY"]= "Germany"
output["YEAR"]= "1995"
output["RELEASEDATE"]= "September 4, 1995"
output["DISCNUMBER"]= "1"
output["TRACKS"]= "1|2|3|4|5|6|7|8|9|10|11|12|13|14|15|"
output["ARTIST"]= "Patrick Pulsinger|Damon Wild &amp; Tim Taylor|Joey Beltram|Magenta|Bandulu|Nexus 6|B.C.|Manuel And Clive|Planetary Assault Systems|Rotortype|Clementine|Sound Enforcer|Transits Of Tone|Planetary Assault Systems|Phrenetic System|"
output["TITLE"]= "Construction Tool|Bang The Acid|Drome|Boost!|Presence|Ab-Chic (Acrid Abeyance Remix)|Stronghold|Recognised|In From The Night|Be Yourself|Breaking Point|Re-Enforcement|Stormer|Starway Ritual|Wayfarer|"
output["DJMIX"]= "CJ Bolland, "
output["TMP"]= ""
output["COMPILED"]= "CJ Bolland, "
output["TMPCR"]= "<role>Written By</role><name>Patrick Pulsinger</name>|<role>Written By</role><name>Damon Wild &amp; Tim Taylor</name>|<role>Written By</role><name>Joey Beltram</name>|<role>Written By</role><name>Cari Lekebusch</name>|<role>Written By</role><name>Bandulu</name>|<role>Remix [Uncredited]</role><name>Acrid Abeyance</name><role>Written By</role><name>E-Harmonix</name><role>Written By</role><name>Tom De Luxe</name>|<role>Written By</role><name>B.C.</name>|<role>Written By</role><name>Manuel And Clive</name>|<role>Written By</role><name>Luke Slater</name>|<role>Written By</role><name>Cari Lekebusch</name>|<role>Written By</role><name>Luke Slater</name>|<role>Written By</role><name>Dave Angel</name>|<role>Written By</role><name>Chris Hawkins</name><role>Written By</role><name>John Litchfield</name><role>Written By</role><name>Leigh Savage</name>|<role>Written By</role><name>Luke Slater</name>|<role>Written By</role><name>Axel Stephenson</name><role>Written By</role><name>Frederico Santini</name>|"
output["Error"]= "<OK>"

Debug log says tags are fine but preview window messes everything up:



This happens when I edit line 332 from:
CODE
outputto "TRACK"

to:
CODE
outputto "TRACKS"

or add "TRACKS" tag anyhow.
I believe we will need help from mp3tag developers.
I attached latest version of my script in this post.
EDIT: Removed - outdated script.
Innuendo
QUOTE (Pufas @ Oct 18 2009, 05:58) *
1. Personaly I don't like storing art data inside mp3, but since a lot of users does, I will add it.


Don't feel like you need to add it on my account. I use a different program to get my album art as I like it to be certain sizes so the functionality is not that important to me. I was just making a comment on it.

QUOTE
2. About that mess with tracknumbers: this was caused by saving tracknumber tag. It looks like mp3tag does not like that, and prefers counting files by himself. I guess I'll have to move vinyl track numbers to some other tag.


You'll think of a way, I'm sure. You're very clever. I don't think many other people have made the leap to writing tagging scripts that work in tandem with action scripts so that shows me you have more ingenuity than a lot of us.

All we need now is for Florian to add a way to invoke action scripts from within tagging scripts (and maybe vice versa) and there's no limits to what you'll be able to accomplish! smile.gif

I'm really looking forward to seeing what you add next. It's always a pleasant surprise.
Innuendo
QUOTE (Pufas @ Oct 18 2009, 09:43) *
I believe we will need help from mp3tag developers.
I attached latest version of my script in this post.


Thanks for the quick turn-around! Maybe you could take a look at the other discogs scripts here in the forum? Or perhaps start up a conversation with Dano. He seems to be the other scripting genius here and he's got a Discogs script of his own so I am sure he could probably tell you where the problem is.
Pufas
Yeah, I think I'll do that.
Pufas
Thanks to Dano, everything seem to work now. I'll finish editing script and re-post it.
Innuendo
QUOTE (Pufas @ Oct 18 2009, 14:02) *
Thanks to Dano, everything seem to work now. I'll finish editing script and re-post it.


Geez, Pufas...you're like a machine! Post a script, take two years off, and then return with a fury! LOL!

Thanks!
Pufas
QUOTE (Innuendo @ Oct 18 2009, 20:34) *
Geez, Pufas...you're like a machine! Post a script, take two years off, and then return with a fury! LOL!

Thanks!

Thanks blush.gif

Edited first post and posted last version of my script. Next I'm planing to add TOTALTRACKS for vinyls, add DISKSIDENAME and get notes working properly.
Innuendo
QUOTE (Pufas @ Oct 18 2009, 15:09) *
Edited first post and posted last version of my script. Next I'm planing to add TOTALTRACKS for vinyls, add DISKSIDENAME and get notes working properly.


Not having much luck with v1.12. I enter a Discogs ID and when the "adjust tag information" window opens up I get the DISCOGSID field in the "Additional information box" and the file in the "Length/Filename" box. Everything else is blank.
Pufas
QUOTE (Innuendo @ Oct 19 2009, 00:10) *
Not having much luck with v1.12. I enter a Discogs ID and when the "adjust tag information" window opens up I get the DISCOGSID field in the "Additional information box" and the file in the "Length/Filename" box. Everything else is blank.

Yeah, script was working just fine, somehow I managed to screw it up and upload. I hope to fix this soon. I guess I was to tired yesterday.

EDIT: Fixed & reposted.
Innuendo
No worries. I just thought I had done something on my end to break it. I'll try this new version and report back.
Innuendo
Just tried it and the tracks window worked beautifully. The only problem I see left is when there is more than one person's name in some of the fields.

With some tags you nailed it coz I see:

ENGINEER Person1, Person2

PRODUCER Person1, Person2

But in other fields I see:

ARTWORK Person1Person2

PHOTOGRAPHY Person1Person2

I guess your script doesn't take into account that there might be one than one person who worked on Artwork and Photography.
Pufas
QUOTE (Innuendo @ Oct 19 2009, 16:19) *
Just tried it and the tracks window worked beautifully. The only problem I see left is when there is more than one person's name in some of the fields.

With some tags you nailed it coz I see:

ENGINEER Person1, Person2

PRODUCER Person1, Person2

But in other fields I see:

ARTWORK Person1Person2

PHOTOGRAPHY Person1Person2

I guess your script doesn't take into account that there might be one than one person who worked on Artwork and Photography.


Yeah, I'm working on that at the moment.
Pufas
Finally done fixing, all seem to work now (I hope). As always new version of the script is in the first post.
Innuendo
QUOTE (Pufas @ Oct 19 2009, 16:31) *
Finally done fixing, all seem to work now (I hope). As always new version of the script is in the first post.


Okay, I had time to try it....I noticed VOCALS tag gets set to the person listed in the Vocals field on the Discogs site, but the Discogs listing Lead Vocals is ignored by your script.
Pufas
QUOTE (Innuendo @ Oct 20 2009, 04:55) *
Okay, I had time to try it....I noticed VOCALS tag gets set to the person listed in the Vocals field on the Discogs site, but the Discogs listing Lead Vocals is ignored by your script.


Hmmm, worked fine for me with this. Could you please post what release you where tagging?
morrison
nice work Pufas book.gif , thanks you
Innuendo
QUOTE (Pufas @ Oct 20 2009, 03:15) *
Hmmm, worked fine for me with this. Could you please post what release you where tagging?


I think what we're dealing with is Discogs not being consistent with how information is displayed. I noticed on your example track the Lead Vocals are listed for each track. However, the release I was testing lists the vocals and lead vocals down in the credits as seen here.

As you can see from the layout of this release it's an excellent test for scripts as it has numerous engineer, photography, and artwork entries. It'd be really nice if the "Notes" section could end up in a tag somewhere, too.

Hope you don't see all my messages as complaining. I just want to help you work all the bugs out. smile.gif
Pufas
QUOTE (Innuendo @ Oct 20 2009, 14:35) *
I think what we're dealing with is Discogs not being consistent with how information is displayed. I noticed on your example track the Lead Vocals are listed for each track. However, the release I was testing lists the vocals and lead vocals down in the credits as seen here.

As you can see from the layout of this release it's an excellent test for scripts as it has numerous engineer, photography, and artwork entries. It'd be really nice if the "Notes" section could end up in a tag somewhere, too.

Hope you don't see all my messages as complaining. I just want to help you work all the bugs out. smile.gif


Yes, I'll see what I can do. I'll be working with notes, as soon as we're done with credits.
About "complaining" - well, I'm glad to hear it. smile.gif
Innuendo
QUOTE (Pufas @ Oct 20 2009, 12:20) *
Yes, I'll see what I can do. I'll be working with notes, as soon as we're done with credits.
About "complaining" - well, I'm glad to hear it. smile.gif


Here is another example of where your otherwise excellent script picks up the backup vocals instead of the lead vocals.
Pufas
Fixed & re-posted. Now I'll get on to NOTES.
BTW, if you know any release with heavily formatted notes (italic, bold, hyperlinks and ect.), please post it, that would be helpful.
Innuendo
QUOTE (Pufas @ Oct 20 2009, 14:07) *
Fixed & re-posted. Now I'll get on to NOTES.
BTW, if you know any release with heavily formatted notes (italic, bold, hyperlinks and ect.), please post it, that would be helpful.


I've been looking for some notes like that, but I guess I either have boring music or nothing really note-worthy as all the releases I have checked so far don't have any formatting like that at all.
Pufas
QUOTE (Innuendo @ Oct 22 2009, 20:26) *
I've been looking for some notes like that, but I guess I either have boring music or nothing really note-worthy as all the releases I have checked so far don't have any formatting like that at all.


I'm done with the notes, but I'll post when I'll fix some more stuff.
Innuendo
QUOTE (Pufas @ Oct 22 2009, 14:33) *
I'm done with the notes, but I'll post when I'll fix some more stuff.


I'll keep checking back looking for it then.
morrison
cannot receive information about this release - http://www.discogs.com/release/1671758 (I fix this in my temporary version). I think this is because one of main field (Style) is empty.

sorry for my English
Pufas
QUOTE (morrison @ Oct 23 2009, 10:49) *
cannot receive information about this release - http://www.discogs.com/release/1671758 (I fix this in my temporary version). I think this is because one of main field (Style) is empty.

sorry for my English


I know this bug and I'm working on that.
morrison
if this can help, I fix this with this:

# STYLE
gotochar 1
findinline "</genres>"
if "<styles>"
outputto "STYLE"
replace "</style><style>" ", "
findinline "<style>"
sayuntil "</style>"
endif

upd:

and another strange moment in your script:
if "Vocals"
outputto "VOCALS"
outputto "VOCALS"
Pufas
QUOTE (morrison @ Oct 23 2009, 11:07) *
if this can help, I fix this with this:

# STYLE
gotochar 1
findinline "</genres>"
if "<styles>"
outputto "STYLE"
replace "</style><style>" ", "
findinline "<style>"
sayuntil "</style>"
endif

upd:

and another strange moment in your script:
if "Vocals"
outputto "VOCALS"
outputto "VOCALS"


thank you for caring, but i would had it fixed that long long time ago, but i believe i encountered some mp3tag bugs. I've asked dano for some help, and i'm waiting for reply.

and that 2x outputto "VOCALS" - it's just a minor type error. Still thank you for reporting that.
morrison
QUOTE (Pufas @ Oct 24 2009, 01:19) *
thank you for caring, but i would had it fixed that long long time ago, but i believe i encountered some mp3tag bugs. I've asked dano for some help, and i'm waiting for reply.

and that 2x outputto "VOCALS" - it's just a minor type error. Still thank you for reporting that.


NP, I reported only for your convenience smile.gif
Pufas
I added new version of script. However "empty fields bug" remains unsolved. Script contains code which "should" solve everything. If someone finds what's wrong with it, that would be nice. For now, I'll wait a bit for dano's reply.
dano
With Mp3tag 2.44e it will not display empty tag fields anymore, so to remove a temporary tag field, just set it empty:
set "TMP1"

Then you won't see it anymore in the tag window.

Btw why do you use
say " "
on all notes fields e.g.
outputto "VOCALS"
say " "
Windjammer
QUOTE (dano @ Oct 24 2009, 14:08) *
With Mp3tag 2.44e it will not display empty tag fields anymore, so to remove a temporary tag field, just set it empty:
set "TMP1"

Then you won't see it anymore in the tag window.

Btw why do you use
say " "
on all notes fields e.g.
outputto "VOCALS"
say " "


This is probably correct, but Pufas scrip adds a space " " to all empty tags so it still generates a lot of "empty" tags...
Windjammer
Pufas, this script is, like the Americans say, awesome!

I'm working with this release right now and there seem to be a quite few things that don't work as expected. This is a very complex album so I'm not so surprised.

http://www.discogs.com/Ti%C3%ABsto-Kaleido...release/1950200

The script does not grab:

CREDITS (over all) as in writing the full content into the %credits% tag. It grabs all individual parts in the CREDITS except "Written-By, Co-producer - D.J. Waakop Reijers-Fraaij* , T.Verwest*" where it only grabs the Co-producer. BTW I love the way you get the full names and removes numbers, (2) ,and stars, *. The "Written-By" tag comes out blank.

CREDITS (individual) comes out in the TMPCR tag as
<role>Featuring</role><name>Jónsi</name><role>Vocals</role><name>J.Young</name><role>Written By</role><name>Jón Þór Birgisson</name>
So here you would like to have the Featuring put in the FEATURING tag, the Vocals in the VOCALS tag and the Written By in the COMPOSER tag.

I understand the problem of having 2 input sources for the same tag. In my personal opinion I think it's wise to split them (Over All & Individual) into different tags and then use Actions in mp3tag to distribute them into what ever tag you want.

This script is a gold mine for me! Tagging music is so much fun now! Now I'm only waiting for iTunes being able to use all tags...

EDIT: Spelling Errors.
Innuendo
QUOTE (Windjammer @ Oct 24 2009, 09:37) *


Holy crap...calling that release complex is an understatement. I don't know what I was expecting when I clicked that link, but wow...it's almost like each song has its own stand-alone list of credits.

Lucky for us, Pufas seems to thrive on challenges like this. I'll be very surprised if he can't solve it.
Pufas
QUOTE (dano @ Oct 24 2009, 13:08) *
With Mp3tag 2.44e it will not display empty tag fields anymore, so to remove a temporary tag field, just set it empty:
set "TMP1"

Then you won't see it anymore in the tag window.

Btw why do you use
say " "
on all notes fields e.g.
outputto "VOCALS"
say " "


I added this to remove any present tags without deleting tags inside mp3tag (saves time).
Pufas
QUOTE (Windjammer @ Oct 24 2009, 15:37) *
Pufas, this script is, like the Americans say, awesome!

I'm working with this release right now and there seem to be a quite few things that don't work as expected. This is a very complex album so I'm not so surprised.

http://www.discogs.com/Ti%C3%ABsto-Kaleido...release/1950200

The script does not grab:

CREDITS (over all) as in writing the full content into the %credits% tag. It grabs all individual parts in the CREDITS except "Written-By, Co-producer - D.J. Waakop Reijers-Fraaij* , T.Verwest*" where it only grabs the Co-producer. BTW I love the way you get the full names and removes numbers, (2) ,and stars, *. The "Written-By" tag comes out blank.

CREDITS (individual) comes out in the TMPCR tag as
<role>Featuring</role><name>Jónsi</name><role>Vocals</role><name>J.Young</name><role>Written By</role><name>Jón Þór Birgisson</name>
So here you would like to have the Featuring put in the FEATURING tag, the Vocals in the VOCALS tag and the Written By in the COMPOSER tag.

I understand the problem of having 2 input sources for the same tag. In my personal opinion I think it's wise to split them (Over All & Individual) into different tags and then use Actions in mp3tag to distribute them into what ever tag you want.

This script is a gold mine for me! Tagging music is so much fun now! Now I'm only waiting for iTunes being able to use all tags...

EDIT: Spelling Errors.



Thank you for this detailed description, but I think you *FORGOT* to apply actions which are included, didn't you? (BTW, read my first post). Your *FAT* tiesto release tagged just fine for me, except minor issues in NOTES tag (which will be fixed in next update).
There is no such tag as %CREDITS%. All *credits* are divided into bunch of tags (i.e.):
Written By goes to AUTHOR tag, Vocals, Leading Vocals, Backing Vocals goes to VOCALS and ect. These tags are filled: overall credits + per track credits (i.e.): in this release
http://www.discogs.com/Ti%C3%ABsto-Kaleido...release/1950200
track 1 would have AUTHOR tag "DJ Waakop Reijers, Tijs Verwest, Jón Þór Birgisson".
You get the idea.

EDIT: v1.17 available. However "empty fields bug" still remains unsolved.
morrison
Hello Pufas
I tried to add a function to get CD names for their own purposes. (You do not plan to add it to your script?) And found the deadly discogs release - http://www.discogs.com/Raja-Ram-The-Anthol...release/1095287. Your script, and my modification - mp3tag die from lack of memory ..

UPD

like a temporary fix, I commented first "outputto "TMP2"" line in TOTALTRACKS section.
This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.
Invision Power Board © 2001-2014 Invision Power Services, Inc.