IPB

Welcome Guest ( Log In | Register )

 
Reply to this topicStart new topic
> [F] Discogs fetch for artist adds comma to name field
MarkC
post May 11 2017, 16:22
Post #1


Member


Group: Full Members
Posts: 13
Joined: 29-December 14
From: Boulder, Colorado
Member No.: 20244
Mp3tag Version: 2.82a



I've just tagged my first album using the 2.82 release and see that the bug detailed in this field is still there.

I realized it wasn't listed here in the bug reports forum.

https://forums.mp3tag.de/index.php?showtopi...&hl=discogs
Go to the top of the page
 
+Quote Post
ohrenkino
post May 11 2017, 18:07
Post #2


Member


Group: Full Members
Posts: 9228
Joined: 9-December 09
From: Norddeutschland / Northern Germany
Member No.: 11458
Mp3tag Version: 2.85



ZITAT(MarkC @ May 11 2017, 17:22) *
I've just tagged my first album using the 2.82 release and see that the bug detailed in this field is still there.

I realized it wasn't listed here in the bug reports forum.
...

I still think that discussions about the advantages and shortcomings of web source scripts should be held in the corresponding web sources forum.
There are at least 2 discogs web source scripts so it is a little guess work which one you could mean.
Web sources scripts are not updated automatically: so did you implement the fix that was mentioned in the thread that you referenced?

This post has been edited by ohrenkino: May 11 2017, 18:09


--------------------
42 - wie war die Frage / what was the question / quelle était la question
Go to the top of the page
 
+Quote Post
MarkC
post Jun 15 2017, 00:31
Post #3


Member


Group: Full Members
Posts: 13
Joined: 29-December 14
From: Boulder, Colorado
Member No.: 20244
Mp3tag Version: 2.82a



QUOTE (ohrenkino @ May 11 2017, 19:07) *
I still think that discussions about the advantages and shortcomings of web source scripts should be held in the corresponding web sources forum.
There are at least 2 discogs web source scripts so it is a little guess work which one you could mean.
Web sources scripts are not updated automatically: so did you implement the fix that was mentioned in the thread that you referenced?


No I didn't try it.

The discogs feature I'm trying to use is the ONE shipped with MP3TAG. I've been a user for so long, that I wasn't sure if I'd installed a plugin to get discogs functionality, so I did an install on a different machine. I had not, the discogs I'm trying to use is shipped embedded in MP3TAG.

So it seemed reasonable to report here, so it could be fixed at source. Sorry if I wasn't clear originally.
Go to the top of the page
 
+Quote Post
DetlevD
post Jun 15 2017, 11:12
Post #4


Member


Group: Full Members
Posts: 6718
Joined: 26-May 06
From: Wuppertal, Germany, Planet Earth
Member No.: 3194
Mp3tag Version: 2.85



QUOTE (MarkC @ May 11 2017, 17:22) *
I've just tagged my first album using the 2.82 release and see that the bug detailed in this field is still there. ...

Just to make sure, that you apply the last version of the Mp3tag standard script "discogs.src":
Mp3tag version: 2.82a, script size: 4193 Byte.
Inner change log entry: # [2016-01-31] v1.03

Within this export script there is a code line ...
CODE
json_select_many "artists" "name" ", "

and a following block of related commands ...
which in my opinion, can handle trailing ", ".

You should check your Mp3tag installation, working with the newest version of the source script "discogs.src".

DD.20170615.1212.CEST

This post has been edited by DetlevD: Jun 15 2017, 11:15


--------------------
* Beyond that, don't ask, when you don't know what to do with the answer. *
♥ home is where the heart is ♥
Go to the top of the page
 
+Quote Post
Florian
post Jun 15 2017, 13:31
Post #5


Developer


Group: Admin
Posts: 8101
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.85



QUOTE (MarkC @ Jun 15 2017, 01:31) *
The discogs feature I'm trying to use is the ONE shipped with MP3TAG. I've been a user for so long, that I wasn't sure if I'd installed a plugin to get discogs functionality, so I did an install on a different machine. I had not, the discogs I'm trying to use is shipped embedded in MP3TAG.

So it seemed reasonable to report here, so it could be fixed at source. Sorry if I wasn't clear originally.

Thanks for taking the time and for bringing this to my attention. I'll fix it with the next release.

Kind regards
– Florian


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post
Florian
post Jun 17 2017, 09:33
Post #6


Developer


Group: Admin
Posts: 8101
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.85



This is now fixed with the latest Development Build Mp3tag v2.82b.

Kind regards
– Florian


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post

Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 19th November 2017 - 20:36