IPB

Welcome Guest ( Log In | Register )

 
Reply to this topicStart new topic
> Added comma in artist filed from discogs, Tags retrieved from discogs often sdd a comma to the artist name
MarkC
post Oct 4 2016, 00:20
Post #1


Member


Group: Full Members
Posts: 13
Joined: 29-December 14
From: Boulder, Colorado
Member No.: 20244
Mp3tag Version: 2.82a



I've been using mp3tag for many years, mostly to tag and update existing mp3 files. Recently I've been copying vinyl to mp3.

I add the vinyl album to my discogs catalog; I record the vinyl to .wav, convert wav to mp3; tag the files using mp3tag retrieved from the exact album from the discogs catalog; and the final stage is to rename the file to tags using the convert menu in mp3tag.

The problem seems to be that on discogs, in this example, the artist name ends in "Jr." When the tags are retrieved from discogs and populated into the artist name field, an additional space/comma/space is added. I don't know if this is additional data being returned by discogs, or a parsing error within mp3tag.

Attached are images that show the problem.

Attached thumbnail(s)
Attached Image
Attached Image
 
Go to the top of the page
 
+Quote Post
poster
post Oct 4 2016, 11:36
Post #2


Member


Group: Full Members
Posts: 1433
Joined: 22-March 09
Member No.: 9241
Mp3tag Version: 2.85



ZITAT(MarkC @ Oct 4 2016, 01:20) *
The problem seems to be that on discogs, in this example, the artist name ends in "Jr." When the tags are retrieved from discogs and populated into the artist name field, an additional space/comma/space is added.

This only seems to happen if there is a comma in front of Jr.
ie. "Sammy Davis Jr." is left just as it is.
Go to the top of the page
 
+Quote Post
MarkC
post Oct 5 2016, 03:20
Post #3


Member


Group: Full Members
Posts: 13
Joined: 29-December 14
From: Boulder, Colorado
Member No.: 20244
Mp3tag Version: 2.82a



QUOTE (poster @ Oct 4 2016, 11:36) *
This only seems to happen if there is a comma in front of Jr.
ie. "Sammy Davis Jr." is left just as it is.


Just so we are clear, it is NOT just this use case.

Here is another example I've ripped from vinyl tonight. The artist is simply George Benson.
Attached thumbnail(s)
Attached Image
Attached Image
 
Go to the top of the page
 
+Quote Post
MarkC
post Oct 7 2016, 18:37
Post #4


Member


Group: Full Members
Posts: 13
Joined: 29-December 14
From: Boulder, Colorado
Member No.: 20244
Mp3tag Version: 2.82a



QUOTE (MarkC @ Oct 5 2016, 03:20) *
Just so we are clear, it is NOT just this use case.

Here is another example I've ripped from vinyl tonight. The artist is simply George Benson.


Also, it is inconsistent. I just ripped Grover Washington Jr Reed Seed album from vinyl to MP3, when tagging with discogs as the source, no extra spaces or comma's were returned to mp3tag.

Maybe it's the discogs API??
Go to the top of the page
 
+Quote Post
awx
post Jan 31 2017, 22:00
Post #5


Member


Group: Full Members
Posts: 12
Joined: 19-September 05
From: Lithuania
Member No.: 2162
Mp3tag Version: 2.80



Hi, I've noticed same problem and solved it this way (talking about default discogs source script). I'm not an expert but checked API output and found comma just right after join in "artists" tag:
CODE
{"join": ",", "name": "Michael Mantra", ...

and this is what I did:

find lines 185-189
CODE
ifnot ""
say " "
sayrest
say " "
endif

change to
CODE
if ","
say ""
else
if ""
say ""
else
say " "
sayrest
say " "
endif
endif

same with the lines bit below just right after:
CODE
json_select "join"
I believe I didn't test all naming options in discogs but those I'm using seems to be fixed.

This post has been edited by awx: Feb 1 2017, 00:03
Go to the top of the page
 
+Quote Post
Charly G
post Apr 9 2017, 23:33
Post #6


Member


Group: Members
Posts: 2
Joined: 26-September 09
Member No.: 10995
Mp3tag Version: 2.44



QUOTE (awx @ Jan 31 2017, 18:00) *
Hi, I've noticed same problem and solved it this way (talking about default discogs source script). I'm not an expert but checked API output and found comma just right after join in "artists" tag:
CODE
{"join": ",", "name": "Michael Mantra", ...

and this is what I did:


Thanks a LOT!! Had the same problem, a little annoying indeed. Your fix was great! Hope it makes it to the next version. As of 2.81 the bug still persists.
Go to the top of the page
 
+Quote Post
Florian
post Jun 17 2017, 09:39
Post #7


Developer


Group: Admin
Posts: 8106
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.85a



The current Development Build Mp3tag v2.82b now comes with an official Discogs web source that fixes this issue.

I've used a different approach than discussed above: ignoring the join separator would concatenate all artists in multi-artist releases.

Kind regards
– Florian


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post

Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 23rd November 2017 - 08:30