IPB

Welcome Guest ( Log In | Register )

 
Reply to this topicStart new topic
> [X] Ctrl+S doesn't save on anything other than Filename
andpeterson
post Jul 31 2017, 08:14
Post #1


Member


Group: Members
Posts: 3
Joined: 31-July 17
Member No.: 23707
Mp3tag Version: v2.83



Pressing Ctrl+S doesn't when editing a text field inside the right pane other than the Filename column doesn't save changes made in the text field.

OS: Windows 10 Pro x64 - Version: 1607 - Build: 14393.1480

Repro rate: 5/5

Repro Steps:
1. In Windows Explorer right click an mp3 file
2. Select Mp3tag
3. Left click on Track, Title, Artist, Album Artist, Album, Discnumber, Year, Genre, or Comment Text fields for the MP3 track loaded into Mp3tag
4. Type some text into text field
5. Press Ctrl+S
6. Observe the field revert back to its original state

Link to recorded steps in mht file: https://drive.google.com/file/d/0B7HF8_5c6b...iew?usp=sharing

Expected Results:
Mp3tag to save changes made in the text field to the track

Actual Results:
Mp3tag reverts changes back to what they were before changes where made

Note:
Clicking outside the text field and\or pressing Enter saves changes to fields but it would be nice to also have Ctrl+S included as it does work in the Filename column.

Go to the top of the page
 
+Quote Post
ohrenkino
post Jul 31 2017, 08:32
Post #2


Member


Group: Full Members
Posts: 9001
Joined: 9-December 09
From: Norddeutschland / Northern Germany
Member No.: 11458
Mp3tag Version: 2.84a



Handling of the tag panel and the files list is different - and I assume that you did your editing in the files list.

Editing in the files list immediately saves the modification as soon as you leave the (editable) field. But not before.
Ctrl-S (or the save icon in the tool bar) write back the data from the tag panel.

So if you are in the state of an unfinished editing process (i.e. you have not left the field where you modified the data), Ctrl-S saves the contents of the tag panel in the file - this leads to the effect that unsaved modifications get overwritten.

If you do not use the keyboard shortcut but click on the tool bar icon, you will not see this effect as you then have left the field in the files list which saves the modification.

Why does editing in the tag panel behave differently?
The tag panel by design allows to edit information for all the selected files - this is not possible in the files list where editing is only possible, if a single file is selected.

So if leaving a field in the tag panel would trigger MP3tag to save the modification, then this could considerably slow down the editing process as the modification from one single field would be written to all the selected files.
Instead you have to tell MP3tag that you have finished editing (all of the fields) and the modifications in all fields get written to the files in one go. This is quicker.

My contribution was meant to be a description of the current function that might shed some light of the possible motivation why MP3tag behaves the way it does.
It does not judge whether this is a bug or not.
The description of Ctrl-S in the help does not say anything more than just "Save tag", yet MP3tag behaves like "Save data in tag-panel to tag"
http://help.mp3tag.de/main_keyboard.html


--------------------
42 - wie war die Frage / what was the question / quelle était la question
Go to the top of the page
 
+Quote Post
andpeterson
post Jul 31 2017, 09:06
Post #3


Member


Group: Members
Posts: 3
Joined: 31-July 17
Member No.: 23707
Mp3tag Version: v2.83



Sorry for the spamming @_@ it would be helpful not to be on mobile right now.

I fully understand where you are coming from on a technical standpoint but my reason for bringing this up mostly was because when using Ctrl-S in the Filename column it will automatically push the change and save it to the file. Where as any other column won't which makes the feature a little confusing when it works in one specific place but none of the others

This post has been edited by andpeterson: Jul 31 2017, 09:13
Go to the top of the page
 
+Quote Post
poster
post Jul 31 2017, 09:11
Post #4


Member


Group: Full Members
Posts: 1387
Joined: 22-March 09
Member No.: 9241
Mp3tag Version: 2.84



The Save-button, Save-Tag and CTRL-s only produce a result to changed tags in the columns, that are not in the tag-panel.
If you define a tag-field in the column-view that ist not in the tag-panel CTRL-s works as you wish.

This is by design and not a bug.
Go to the top of the page
 
+Quote Post
ohrenkino
post Jul 31 2017, 09:21
Post #5


Member


Group: Full Members
Posts: 9001
Joined: 9-December 09
From: Norddeutschland / Northern Germany
Member No.: 11458
Mp3tag Version: 2.84a



ZITAT(andpeterson @ Jul 31 2017, 10:06) *
Sorry for the spamming @_@ it would be helpful not to be on mobile right now.

I fully understand where you are coming from on a technical standpoint but my reason for bringing this up mostly was because when using Ctrl-S in the Filename column it will automatically push the change and save it to the file. Where as any other column won't which makes the feature a little confusing when it works in one specific place but none of the others

I doubt that this has anything to do with the filename but whether that field is actually displayed in the tag panel or not.
Please take any other field in the files list that has no representation in the tag panel and press Ctrl-S and you will see that the modified data will be saved - and not the previously present piece of information.
As soon as you leave a field in the files list (and the modification is saved) you will see that the field(s) in the tag panel get updated - and so only the uptodate data will be saved if you press Ctrl-S.


--------------------
42 - wie war die Frage / what was the question / quelle était la question
Go to the top of the page
 
+Quote Post

Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 20th September 2017 - 01:15