IPB

Welcome Guest ( Log In | Register )

 
Reply to this topicStart new topic
> [F] Editing file increases its size to 1GB
anil
post Apr 26 2017, 12:22
Post #1


Member


Group: Full Members
Posts: 7
Joined: 29-March 13
Member No.: 17771
Mp3tag Version: 2.54



Mp3tag increases some m4a files' size to 1gb during editing.
Sample file attached.

Version:2.81c
Attached File(s)
Attached File  test_mp3tag.zip ( 160.65K ) Number of downloads: 37
 
Go to the top of the page
 
+Quote Post
ohrenkino
post Apr 26 2017, 13:38
Post #2


Member


Group: Full Members
Posts: 8850
Joined: 9-December 09
From: Norddeutschland / Northern Germany
Member No.: 11458
Mp3tag Version: 2.83i



ZITAT(anil @ Apr 26 2017, 13:22) *
Mp3tag increases some m4a files' size to 1gb during editing.
Sample file attached.

Version:2.81c

foobar2000 reports that the file is corrupt or incomplete.
So I would check the files for integrity first.
Also, please note that nero tags are not supported by MP3tag.


--------------------
42 - wie war die Frage / what was the question / quelle était la question
Go to the top of the page
 
+Quote Post
anil
post Apr 27 2017, 01:07
Post #3


Member


Group: Full Members
Posts: 7
Joined: 29-March 13
Member No.: 17771
Mp3tag Version: 2.54



But foobar2000 (and other music related applications on my pc) can play it and read its tag.
Let's assume that the file is corrupted. Then why does mp3tag save changes successfully and increase the file size instead of showing an error message?
Go to the top of the page
 
+Quote Post
ohrenkino
post Apr 27 2017, 05:58
Post #4


Member


Group: Full Members
Posts: 8850
Joined: 9-December 09
From: Norddeutschland / Northern Germany
Member No.: 11458
Mp3tag Version: 2.83i



ZITAT(anil @ Apr 27 2017, 02:07) *
But foobar2000 (and other music related applications on my pc) can play it and read its tag.
Let's assume that the file is corrupted. Then why does mp3tag save changes successfully and increase the file size instead of showing an error message?

I am not sure that I understand what you are getting at.
Do you want better error messages?
MP3tag does not check the plausibility of the header information.
Broken VBR headers do not get corrected and lead to strange lengths and data rates.
Corrupt M4a files may lead to files with the size of 1GB.
As soon as this (audio) data is fixed, you do not get any hicups.
It is just a demonstration of the GIGO principle.

This post has been edited by ohrenkino: Apr 27 2017, 06:09


--------------------
42 - wie war die Frage / what was the question / quelle était la question
Go to the top of the page
 
+Quote Post
anil
post Apr 27 2017, 07:38
Post #5


Member


Group: Full Members
Posts: 7
Joined: 29-March 13
Member No.: 17771
Mp3tag Version: 2.54



If increasing the file size 6261272.307929181-fold is not a bug, then i have a feature request.
Mp3tag should stop or warn the user if the new file size exceeds for example 200% of initial file size.
Go to the top of the page
 
+Quote Post
ohrenkino
post Apr 27 2017, 07:58
Post #6


Member


Group: Full Members
Posts: 8850
Joined: 9-December 09
From: Norddeutschland / Northern Germany
Member No.: 11458
Mp3tag Version: 2.83i



ZITAT(anil @ Apr 27 2017, 08:38) *
If increasing the file size 6261272.307929181-fold is not a bug, then i have a feature request.
Mp3tag should stop or warn the user if the new file size exceeds for example 200% of initial file size.

MP3tag follows that what has been written in the header of the file. The header also tells how many
And apparently you have stored utter garbage there.
Again: what happens if you repair the file?
Does MP3tag increase the file size in the way you described it? If that is the case, then you probably have a bug.

The 200% increase can easily be achieved if you add a big cover to a very short audio part. No bug there.


--------------------
42 - wie war die Frage / what was the question / quelle était la question
Go to the top of the page
 
+Quote Post
anil
post Apr 27 2017, 09:12
Post #7


Member


Group: Full Members
Posts: 7
Joined: 29-March 13
Member No.: 17771
Mp3tag Version: 2.54



1by1 player is the application that has stored some data which you refer to as "utter garbage" in the file.

When data added by 1by1 is removed, of course everything is fine. Mp3tag can edit it without increasing the size. But the problem is that i want that data there.

Windows explorer can edit the "garbage"d file and the size doesn't change. This is what makes me claim that Mp3tag has a bug. I can use windows but it won't be as fast and powerful as Mp3tag.

QUOTE (ohrenkino @ Apr 27 2017, 08:58) *
The 200% increase can easily be achieved if you add a big cover to a very short audio part. No bug there.

I considered it when i wrote, that's why i said "for example". Don't tell me that developers do what a user "exactly" says when they're adding a feature. There you go:
Abort if (new file size - input size)>(initial size X 2)
Go to the top of the page
 
+Quote Post
Florian
post Apr 27 2017, 09:24
Post #8


Developer


Group: Admin
Posts: 8001
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.83i



Hello anil,

many thanks for your bug report which I can reproduce here. I consider not raising an error message in case malformed data is provided and instead increasing the file size by that extend to be a serious issue and a loop-hole for possible exploits.

I'll analyze the issue and will fix it to the next release.

Kind regards
– Florian


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post
Florian
post Apr 29 2017, 08:38
Post #9


Developer


Group: Admin
Posts: 8001
Joined: 12-December 01
From: Germany, Dresden
Member No.: 203
Mp3tag Version: 2.83i



This is now fixed with Mp3tag v2.82.

The test file you've provided was tagged with an APEv2 and an ID3v1 tag, which are both tag formats not suitable (and not standardized) for MP4 files. Whatever program you've used to add those tags, I'd recommend to not continue using for that task.

Kind regards
– Florian


--------------------
♫ If you like using Mp3tag please donate to support further development.

Go to the top of the page
 
+Quote Post

Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 18th August 2017 - 20:54